22858 - Window resize box can overlap with widgets

Status: RESOLVED INVALID

(Core Graveyard :: Profile: Migration, defect, P3)

Description

[Henri Sivonen (:hsivonen)]

Overview Description:
The 16 pixels by 16 pixels area at the lower right corner of a resizable window
is covered by the standard size box on Mac OS. There should not be other UI
components occupying that space.

Steps to Reproduce:
1) Open the profile migration window

Actual Results:
The size box overlaps with the "Exit" button.

Expected Results:
Expected the space required by the size box to be reserved for the size box
exclusively.

Build Date & Platform Bug Found:
1999122908, Mac OS 8.5.1

Comment 1

[Eli Goldberg]

UPM problem; reassigning.

---

Bhuvan, is this a UPM-specific implementation problem?

(If it's not just specific to UPM, please reassign to XP Toolkit/Widgets,
Assigned to: [e-mail], QA Assigned to: [e-mail].)

Thanks!

Comment 2

[racham]

This behavior is new and I was wondering if any of the new toolkit changes
pushed this. Reassigning to XPToolkit group. If we need to modify anything
in our XUL files, please let us know. Adding gayatri and ben to the cc list.

Comment 3

[Peter Trudelle]

This is using the wrong kind of window on the Mac. reassigning to danm as p3 for
m15

Comment 4

[Peter Trudelle]

Mass-moving all M16 non-feature bugs to M17, which we still consider to be 
part of beta2

Comment 5

[Dan M]

  Perhaps there have been some UI changes since this bug was filed. I'm taking 
the "profile migration window" mentioned in the original writeup to be the little 
progress dialog that shows while a Navigator profile is being migrated. That 
window is resizeable and, I'd say, shouldn't be. I think that's all there is to 
this bug.
  Unfortunately, this window is created using deprecated C++ 
(nsIAppShellService::CreateTopLevelWindow in nsProfile.cpp), so the window isn't 
easily made not resizeable. This wants to be changed over to using JS OpenDialog, 
examples of which are all over the code (nsCommonDialogs::DoDialog, for 
instance). That's the best way to open a window from C++, and it's easily made 
not resizeable from there.
  Reassigning to the person CVS Blame fingers as the original caller of the 
function. Seth, you probably want to bounce it to someone else. This should all 
be straightforward, and it's not a big deal in any case.

Comment 6

[(not reading, please use [e-mail] instead)]

re-assign to racham.  the code that opens the window is his.

Comment 7

[racham]

This one is already fixed on nsProfile.cpp. I used the following to fix the 
chrome style. Then use CHROME_STYLE as your style tag. In case of migration, 
profile manager's toplevel window is loaded with confirm migration text.

#if defined (XP_MAC)
#define CHROME_STYLE nsIWebBrowserChrome::windowBordersOn | 
nsIWebBrowserChrome::windowCloseOn
#else /* the rest */
#define CHROME_STYLE nsIWebBrowserChrome::allChrome
#endif 

In case of this bug, the window that has the resizable handle on it is the 
toplevelwindow opened by nsPrefMigration.cpp 
(http://lxr.mozilla.org/seamonkey/source/profile/pref-migrator/src/nsPrefMigrati
on.cpp#329)

Reassigning to Don Bragg. The above should fix it.

Comment 8

[Cathleen]

set target milestone to M17

Comment 9

[Daniel Veditz [:dveditz]]

Adding nsbeta3 keyword to bugs which already have nsbeta3 status markings so 
the queries don't get all screwed up.

Comment 10

[Daniel Veditz [:dveditz]]

Resetting missed milestones

Comment 11

[dbragg]

Reassigning profile migration bugs to the current owner

Comment 12

[(not reading, please use [e-mail] instead)]

mass re-assign.

Comment 13

[Josh Aas]

This bug is no longer valid. Resize boxes on Mac OS X don't conflict with widgets the way they did in classic Mac OS, and we don't have any other issues of this sort at this time.

Comment 14

[Pulsebot]

Pushed by ffxbld-merge:
https://hg.mozilla.org/releases/mozilla-beta/rev/c39e9d5d45b1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22858 - Set all @color/tab_tray_item_media_stroke usages to @color/photonWhite