Closed Bug 228839 Opened 21 years ago Closed 9 days ago

In a bookmarks toolbar folder's menu, open bookmark in new tab on middle-click

Categories

(Camino Graveyard :: Toolbars & Menus, enhancement)

PowerPC
macOS
enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED INCOMPLETE

People

(Reporter: jdance, Unassigned)

References

Details

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.6b) Gecko/20031213 Camino/0.7+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.6b) Gecko/20031213 Camino/0.7+

This is part of a suite of bookmark toolbar enhancements to bring middle-click
and cmd-click support for Camino's bookmarks toolbar, similar to Firebird. I
will post all the bug numbers in a comment once they are up.

This bug is only for middle-click support inside a bookmark toolbar folder,
similar to bug 228478. Upon middle-click, the same behavior as Cmd-click should
occur. My suggestion is that the bookmark should be opened in a new tab and that
tab should be given focus.

Reproducible: Always

Steps to Reproduce:
1. Click on a bookmark folder in your bookmarks toolbar.
2. Middle-click on a bookmark in that folder.


Actual Results:  
The bookmark is loaded in the current tab.

Expected Results:  
The bookmark should be loaded in a new tab, and that tab should be given focus.
The bug numbers are:
bug 228478 - Cmd-click support for bookmarks in folders
bug 228839 - Middle-click support for bookmarks in folders
bug 228840 - Middle-click support for bookmarks not in folders

Also, for this bug: the focus should depend on the preference, "Load opened
windows or tabs in the background" in Tabbed Browsing. If this is checked, do
not give focus to the new tab.
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Target Milestone: --- → Camino1.0
Is this something likely to get fixed in 1.0, or should we move it?
In reply to my comment... not 1.0 material. Moving to 1.1.
Target Milestone: Camino1.0 → Camino1.1
Håkan, is this something you'd be interested in looking at?
QA Contact: toolbars
Backend-wise, the same code needs fixing for this bug as for 228840. Seems like a lot needs to be rewritten there unfortunately.. :(

If I get around to fix that one, I'll try to do this as well. Marking dependency so I don't forget.
Depends on: 228840
Assignee: mikepinkerton → nobody
Status: ASSIGNED → NEW
Pushing to 1.2, since Håkan isn't going to have time to look at this before 1.1.
Target Milestone: Camino1.1 → Camino1.2
Target Milestone: Camino1.6 → ---
This bug needs bug 412391 fixed, not bug 228840.
Depends on: 412391
No longer depends on: 228840
Summary: Inside a bookmarks toolbar folder, open new tab on middle-click → In a bookmarks toolbar folder's menu, open bookmark in new tab on middle-click
Status: NEW → RESOLVED
Closed: 9 days ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.