229413 - necko assumes native filesystem encoding is ascii compatible

Status: RESOLVED WONTFIX

(Core :: Networking, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

/netwerk/base/src/nsDownloader.cpp, line 118 -- rv =
mLocation->AppendNative(nsDependentCString(buf, 12));
/netwerk/cache/src/nsDiskCacheDevice.cpp, line 1037 -- rv =
uniqueDir->AppendNative(NS_LITERAL_CSTRING("Trash"));
/netwerk/cache/src/nsDiskCacheDevice.cpp, line 1052 -- rv =
parentDir->AppendNative(NS_LITERAL_CSTRING("Cache"));
/netwerk/cache/src/nsDiskCacheDevice.cpp, line 1129 -- rv =
directory->AppendNative(NS_LITERAL_CSTRING("Cache"));
/netwerk/cache/src/nsDiskCacheMap.cpp, line 153 -- rv =
localFile->AppendNative(NS_LITERAL_CSTRING("_CACHE_MAP_"));
/netwerk/cache/src/nsDiskCacheMap.cpp, line 874 -- rv =
file->AppendNative(nsDependentCString(name));
/netwerk/cache/src/nsDiskCacheMap.cpp, line 910 -- rv =
file->AppendNative(nsDependentCString(name));
/netwerk/cookie/src/nsCookieService.cpp, line 395 --
mCookieFile->AppendNative(NS_LITERAL_CSTRING(kCookieFileName));
/netwerk/cookie/src/nsCookieService.cpp, line 454 --
mCookieFile->AppendNative(NS_LITERAL_CSTRING(kCookieFileName));
/netwerk/protocol/about/src/nsAboutBloat.cpp, line 106 -- rv =
file->AppendNative(NS_LITERAL_CSTRING("bloatlogs"));
/netwerk/protocol/about/src/nsAboutBloat.cpp, line 131 -- rv =
file->AppendNative(dumpFileName);
/netwerk/test/TestFileInput.cpp, line 350 -- rv =
localFile->AppendNative(nsDependentCString(entry->name));
/netwerk/test/TestFileInput2.cpp, line 390 -- rv = outSpec->AppendNative(leafName);

Comment 1

[Alfred Kayser]

It is just about this?
r/AppendNative(NS_LITERAL_CSTRING("filename.ext"))/AppendLiteral("filename.ext")/

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

yeah, but at this point it's unclear if this is desired; given bug 231243, probably not.