Closed
Bug 229476
Opened 21 years ago
Closed 21 years ago
about:cache title capitalization inconsistent
Categories
(Core :: Networking: Cache, defect)
Tracking
()
VERIFIED
FIXED
People
(Reporter: jmd, Assigned: darin.moz)
Details
Attachments
(2 files)
1.62 KB,
patch
|
bzbarsky
:
review+
darin.moz
:
superreview-
|
Details | Diff | Splinter Review |
3.27 KB,
patch
|
bzbarsky
:
review+
darin.moz
:
superreview+
|
Details | Diff | Splinter Review |
Number of entries: 457 Maximum storage size: 8192 KiB Storage in use: 5402 KiB Inactive Storage: 4328 KiB Here, "Inactive Storage" has its second word capitalized. None of the others do. And for individual entries: Key: http://graphics7.nytimes.com/images/2003/12/26/... Data size: 151800 Bytes Fetch count: 3 Last Modified: Fri Dec 26 15:45:25 2003 Expires: Fri Dec 26 17:57:34 2003 Last Mod'd is double-cap'd, and nothing else. Also, "Bytes" being capitalized looks silly, being not a title and mid-"sentence". I'll attach a patch for this minor issue.
Reporter | ||
Comment 1•21 years ago
|
||
Someone can double check with an English prof that the preposition 'of' should remain lowercase but the "In" should be capitalized because it is functioning as an adverb in this case. I've never been good with the whole sentence labeling thing. Either way this is a definite improvement. Reads and looks much better.
Reporter | ||
Comment 2•21 years ago
|
||
Darin, bz, since you two just reviewed another minor "about:cache" change elsewhere, I though you could take a quick look at this one. -thanks
Updated•21 years ago
|
Assignee: general → darin
Component: Browser-General → Networking: Cache
QA Contact: general → cacheqa
Comment 3•21 years ago
|
||
Comment on attachment 138005 [details] [diff] [review] Make capitalization consistent - Table headers as titles (All major words cap'd) Please set review flags if you want reviews.... r=bzbarsky
Attachment #138005 -
Flags: superreview?(darin)
Attachment #138005 -
Flags: review+
Comment on attachment 138005 [details] [diff] [review] Make capitalization consistent - Table headers as titles (All major words cap'd) I disagree with all of your choices except "bytes" consider http://landfill.mozilla.org/mxr-test/seamonkey/search?string=+in+&find=dtd&filt er= ignore calendar since it's almost always wrong. 15:22 < stephend> NEVER 15:22 < stephend> capitalize In 15:22 < stephend> prepositions, never. I'd rather "Sentence style capitalization."
Attachment #138005 -
Flags: superreview?(darin) → superreview-
Reporter | ||
Comment 5•21 years ago
|
||
I think this looks significantly worse, especially for the entry listings which are right-aligned, but whatever, I'll settle for any form of consistency. Besides, this way I can blame timeless.
Reporter | ||
Updated•21 years ago
|
Attachment #138184 -
Flags: superreview?(timeless)
Attachment #138184 -
Flags: review?(bz-vacation)
Comment 6•21 years ago
|
||
timeless can't sr, so it's no use asking him for sr... This needs moa from darin in any case, like I requested; I won't even bother looking at the changes till darin OKs them -- it's just a waste of my time as the first patch showed.
Attachment #138184 -
Flags: superreview?(timeless) → superreview?(darin)
Reporter | ||
Comment 7•21 years ago
|
||
Comment on attachment 138005 [details] [diff] [review] Make capitalization consistent - Table headers as titles (All major words cap'd) If he can't sr +, he shouldn't sr -.
Attachment #138005 -
Attachment description: Capitalization cleanup → Make capitalization consistent - Table headers as titles (All major words cap'd)
Attachment #138005 -
Flags: superreview- → superreview?(darin)
Assignee | ||
Comment 8•21 years ago
|
||
Comment on attachment 138184 [details] [diff] [review] lowercase extra words i vote for "Sentence style capitalization" .. i think it's plenty clear.
Attachment #138184 -
Flags: superreview?(darin) → superreview+
Assignee | ||
Updated•21 years ago
|
Attachment #138005 -
Flags: superreview?(darin) → superreview-
Comment 9•21 years ago
|
||
Comment on attachment 138184 [details] [diff] [review] lowercase extra words r=bzbarsky
Attachment #138184 -
Flags: review?(bz-vacation) → review+
Reporter | ||
Comment 10•21 years ago
|
||
checked in. thanks.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Comment 11•20 years ago
|
||
Comment on attachment 138184 [details] [diff] [review] lowercase extra words - mBuffer.Append("\n<b> Data size: </b>"); + mBuffer.Append("\n<b> Data size:</b>"); Umm, you removed formatting in preformatted text. Those spaces were there for a reason. Though perhaps a space after </b> instead of before it would of been more sensible.
Reporter | ||
Comment 12•20 years ago
|
||
Right you are, Alexey. The fields at the top are in table cells, and they also had the extra space after the colon. I only meant to trim it off of those. Filed bug 239149, and I'll make a patch tomorrow. This bug (capitalization) is fixed.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•