230931 - nsFileStreams.h should not #include nsReadLine.h

Status: VERIFIED FIXED

(Core :: Networking, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

nsReadLine.h contains some static functions; when nsFileStreams includes that it
causes a build warning when nsFileStreams.h is included by nsNetModule.cpp

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 139058 [details] [diff] [review]
patch

r=bzbarsky, though this static function really needs to go away...

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

NS_InitLineBuffer can't easily be moved into a .cpp file, because spellchecker
uses it.

of course spellchecker reimplements NS_ReadLine, as an nsACString& version...

Comment 4

[Boris Zbarsky [:bzbarsky]]

Oy.  a "line" makes no sense for an nsACString&, but whatever.

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

checked in

Comment 6

[benc]

V
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=nsReadLine.h&branch=&root=/cvsroot&subdir=mozilla/netwerk/base/public&command=DIFF_FRAMESET&rev1=1.3&rev2=1.4
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=nsFileStreams.h&branch=&root=/cvsroot&subdir=mozilla/netwerk/base/src&command=DIFF_FRAMESET&rev1=1.29&rev2=1.30