23156 - Reflow targeting wrong - Fieldset should create child frames in nsCSSFrameConstructor

Status: VERIFIED FIXED

(Core :: Layout, defect, P3)

Description

[rods (gone)]

The Dropdown is NOT rolluped when inside table that is inside a fieldset. Once
the combobox is dropped down and you click on it to roll it up an incremental
reflow is generated with the target beng the nsListControlFrame.

The reflow works its way down into the fieldset and into the AreaFrame of the
fieldset. Then somewhere in the block code between the Fieldset's AreaFrame and
the nsTableFrame the reflow gets changed from an incremental reflow to a resize
reflow. And for some reason the resize reflow never gets to nsComboboxFrame or
the nsListControlframe (which is the target).

I will attach a test case.

Comment 1

[rods (gone)]

Attachment: Demostrates the problem

Comment 2

[rods (gone)]

because of this bug I can't turn on my resize reflow optimization for the
combobox.

Note: This probablem does not occur for a select inside a fieldset, or a select
inside of a table, or a select inside just a form.

Comment 3

[rods (gone)]

adding troy to cc list

Comment 4

[rods (gone)]

Ok, one additional comment. The resize optimization code absolutely relies on
there being an incremental reflow when a style change occurs, then followed by
one or more resize reflows that typically all get thrown away. So this bug
really has two problems:
1) The resize reflow never gets to the listcontrolframe
2) The incremental reflow gets converted to a resize reflow (#2 may cause #1 to
happen)

Comment 5

[buster]

Just want to make sure I understand:  this only happens when a combo-box is
inside a table which is inside a fieldset.  If that's true, it might be a
duplicate of a bug assigned to evaughan for fieldset handling of incremental
reflows.  See bug 11537.  Since 11537 is assigned to M13, I'm assigning this one
to M14.

Comment 6

[rods (gone)]

After talking with Troy, it appears that the root of this evil may be the old
style of frame construction where we had frames creating their child frames. The
FieldSetFrame is creating an AreaFrame and the reparenting all the child frames
from the initial child list to it. This may be the problem, or it could be how
the FieldSet processes its reflow command.

reassigning to evaughan.

All of this frame construction should be moved out into the
nsCSSFrameConstructor.

Comment 7

[rods (gone)]

Changed summary

Comment 8

[rods (gone)]

reassigning to me - I have the fix in my tree

Comment 9

[rods (gone)]

Eri, when you turn on the new FeildSet work close this bug out

Comment 10

[Eric Vaughan]

Fixed.

Comment 11

[Chris Petersen]

Fixed in Feb 21 build.

Comment 12

[Pulsebot]

Pushed by ffxbld-merge:
https://hg.mozilla.org/releases/mozilla-beta/rev/1cb9f48e87eb
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23156 - Remove all unused strings marked moz:removedIn <= 95