Closed
Bug 231978
Opened 21 years ago
Closed 18 years ago
strict warnings starting venkman
Categories
(Other Applications Graveyard :: Venkman JS Debugger, defect)
Other Applications Graveyard
Venkman JS Debugger
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: sgautherie, Assigned: rginda)
Details
Attachments
(2 obsolete files)
{ Warning: reference to undefined property tabs[val].selected Source File: chrome://global/content/bindings/tabbox.xml Line: 226 Warning: reference to undefined property parent._tabpanels Source File: chrome://global/content/bindings/tabbox.xml Line: 236 Warning: reference to undefined property container.tabs.childNodes[container.viewCount] Source File: chrome://venkman/content/view-manager.js Line: 1053 Warning: reference to undefined property tabs[val].selected Source File: chrome://global/content/bindings/tabbox.xml Line: 226 Warning: reference to undefined property parent._tabpanels Source File: chrome://global/content/bindings/tabbox.xml Line: 236 } The Browser (non-Venkman) part code is {{ const tabs = this.childNodes; if (0 <= val && val < tabs.length && !tabs[val].selected) { <-- 226 for (var i = 0; i < tabs.length; i++) if (i != val && tabs[i].selected) tabs[i].selected = false; tabs[val].selected = true; for (var parent = this.parentNode; parent; parent = parent.parentNode) { if (parent.localName == 'tabbox') { var tabpanels = parent._tabpanels; <-- 236 // This will cause an onselect event to fire for the tabpanel element. }} The Venkman part code is {{ var view = viewManager.views[viewId]; var tab = container.tabs.childNodes[container.viewCount]; <-- 1053 var label; }}
Assignee | ||
Updated•21 years ago
|
Summary: "Warning: reference to undefined property tabs[val].selected" and "Warning: reference to undefined property parent._tabpanels"; and in <view-manager.js> "Warning: reference to undefined property container.tabs.childNodes[container.viewCount]"; when In <ta… → strict warnings starting venkman
Reporter | ||
Comment 1•20 years ago
|
||
[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.7a) Gecko/20040219] (W98SE) Confirming. (Comment must have been on v1.6.)
Severity: normal → minor
Reporter | ||
Comment 2•20 years ago
|
||
Reporter | ||
Updated•20 years ago
|
Attachment #142871 -
Flags: review?(neil.parkwaycc.co.uk)
Reporter | ||
Comment 3•20 years ago
|
||
On JS.D loading, this code is executed three times, with |.length==1|: two with |c.V=0| :-) third time with |c.V=1| :-(
Reporter | ||
Updated•20 years ago
|
Attachment #142874 -
Flags: review?(rginda)
Assignee | ||
Comment 4•20 years ago
|
||
Comment on attachment 142874 [details] [diff] [review] (Bv1) <view-manager.js> [Checked in: Comment 6] r=rginda
Attachment #142874 -
Flags: review?(rginda) → review+
Reporter | ||
Updated•20 years ago
|
Attachment #142874 -
Flags: superreview?(dveditz+bmo)
Comment 5•20 years ago
|
||
Comment on attachment 142874 [details] [diff] [review] (Bv1) <view-manager.js> [Checked in: Comment 6] sr=dveditz
Attachment #142874 -
Flags: superreview?(dveditz+bmo) → superreview+
Reporter | ||
Comment 6•20 years ago
|
||
Comment on attachment 142874 [details] [diff] [review] (Bv1) <view-manager.js> [Checked in: Comment 6] Check in: { 03/05/2004 14:13 neil%parkwaycc.co.uk mozilla/ extensions/ venkman/ resources/ content/ view-manager.js 1.10 2/1 Bug 213978 Fix strict JS warning p=gautheri@noos.fr r=rginda sr=dveditz } (This was 231978, not 213978...)
Attachment #142874 -
Attachment description: (Bv1) <view-manager.js> → (Bv1) <view-manager.js>
[Checked in: Comment 6]
Attachment #142874 -
Attachment is obsolete: true
Updated•20 years ago
|
Product: Core → Other Applications
Comment 7•18 years ago
|
||
The Venkman warning was fixed, right? If there was something in Venkman left unfixed from the original report, please reopen and patch. :)
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 8•18 years ago
|
||
[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8.1) Gecko/20061030 SeaMonkey/1.1b] (nightly) (W98SE) V.Fixed on MOZILLA_1_8_BRANCH, which includes "Venkman version 0.9.83".
Status: RESOLVED → VERIFIED
Reporter | ||
Comment 9•18 years ago
|
||
Comment on attachment 142871 [details] [diff] [review] (Av1) <tabbox.xml> Obsoleting: the warnings are not there anymore; and I don't remember the details from 2,5 years ago.
Attachment #142871 -
Attachment is obsolete: true
Attachment #142871 -
Flags: review?(neil)
Updated•6 years ago
|
Product: Other Applications → Other Applications Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•