232131 - Relicense xpinstall to tri-license

Status: RESOLVED FIXED

(mozilla.org :: Miscellaneous, task)

Description

[Gervase Markham [:gerv]]

We are relicensing the entire Mozilla codebase to MPL/LGPL/GPL. For no
particular reason, other than it's an average directory, I've decided to start
with xpinstall.

This bug is to allow interested parties to review the performance of the
relicensing script. I will be attaching the patch here. Further relicensings are
expected to proceed without a bug (or all under the same bug number.) 

jst had particular concerns about whitespace; CCing him. It seems that the new
text does not have trailing whitespace, but the bare-line comment characters do.
i.e. you get

+ * the terms of any one of the MPL, the GPL or the LGPL.<no whitespace here>
+ * <one whitespace here>
+ * ***** END LICENSE BLOCK ***** */<no whitespace here>

Is that an issue? If so, I'm sure a fix could be found.

CCing also the two XPInstall owner accounts, in case anyone is watching them.

Gerv

Comment 1

[Gervase Markham [:gerv]]

Attachment: xpinstall diff (gzipped)

Here's the gzipped diff (36k gzipped, 1.1Mb raw).

Gerv

Comment 2

[Gervase Markham [:gerv]]

Oops; forgot to CC jst.

Gerv

Comment 3

[Johnny Stenback (:jst)]

I'd rather see this go in w/o any trailing whitespace in the lisence at all. Can
I help with looking at the script that does these changes?

Comment 4

[Gervase Markham [:gerv]]

Trent is normally really responsive; I'll just drop him a line.

Gerv

Comment 5

[Trent Mick]

I have send an updated relic.py (0.5.7) to Gerv to fix the trailing-whitespace 
problem.

Comment 6

[Gervase Markham [:gerv]]

Attachment: xpinstall diff v.2 (gzipped)

Here's a diff from the latest version of relic, which suppresses the spaces JST
was concerned about. Could anyone with further issues please raise them? Ta :-)


Gerv

Comment 7

[Johnny Stenback (:jst)]

Looks goot to me, fwiw.

Comment 8

[Daniel Veditz [:dveditz]]

xpinstall/packager/unix/deliver.pl lost its usage comment block describing the
script arguments -- Please restore. Other than that it looks great, thanks for
the hard work and perseverance!

Comment 9

[Gervase Markham [:gerv]]

Fixed. Checkin log omitted for brevity :-)

Gerv