232553 - GTK2 build of Mozilla should use gtk2 themed widgets embedded in webpages

Status: RESOLVED DUPLICATE of bug 329846

(Core Graveyard :: GFX: Gtk, defect)

Description

[Laurens Buhler]

User-Agent:       
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.5) Gecko/20040113 Firebird/0.7

If we look at www.google.com in Mozilla under Linux it has these "tk" style
search buttons. On Mozilla in Windows these buttons are drawn after the present
theme in use, this should also be the case for gtk2 builds.

Given that someone uses a gtk2 build these buttons aswell as the dropdown menus
and possibly other widgets (perhaps the radio buttons?) should also use gtk2 for
a consistent look/feel.

Reproducible: Always
Steps to Reproduce:
1. Every site with an embedded widget shows this

Actual Results:  
Widgets are drawn in a tk style

Expected Results:  
Draw these widgets using the gtk2 style presently in use by the system

Comment 1

[Christopher Blizzard (:blizzard)]

bryner, do we have a bug for this yet?

Comment 2

[R.K.Aa.]

dup of bug 7246?

Comment 3

[R.K.Aa.]

*** Bug 249658 has been marked as a duplicate of this bug. ***

Comment 4

[Ernst Sjostrand]

What's the status on this one?

Iv'e heard that this is a WONTFIX since you need to implement CSS color
properties, and you can't do that with GTK2 widgets?

Would be a shame if we never got rid of the ugly "tk" buttons!

Comment 5

[Ernst Sjostrand]

ping?

Comment 6

[nulldomain]

This is definitely a big draw back to have a nice desktop theme and firefox
using these ugly widgets.

Comment 7

[Adam Guthrie]

*** Bug 301729 has been marked as a duplicate of this bug. ***

Comment 8

[Simon Strandman]

Any news on this? :(

Comment 9

[Vidar Haarr (not reading bugmail)]

I had a 30% patch for this that used GTK to render all the widgets, but didn't fix any of the rendering glitches that surfaced, and had problems with focus rectangles for all controls.

Unfortunately the patch got lost when my HDD died some weeks ago, and I haven't found the time to recode it.

For anyone interested in experimenting with this, I think you should start here:
<http://lxr.mozilla.org/seamonkey/source/widget/src/gtk2/nsNativeThemeGTK.cpp#878> (remove the check). Removing this check will lead to Gecko using GTK to render all widgets, and you'll have alot of problems with form widgets in general, but it's the first step.

Please stop posting useless comments.

Comment 10

[Mike Connor [:mconnor]]

This would require significant backend changes and isn't going to happen for Fx2

Comment 11

[Jeff Fortin]

(In reply to comment #10)
> This would require significant backend changes and isn't going to happen for
> Fx2
> 
How come the new firefox 1.5 error pages (such as "website could not be reached"), have a nice GTK2-rendered button "retry" right at the bottom of the message? What's the difference between that one and the "normal" forms in webpages? I would really like to know.

Comment 12

[Adam Guthrie]

Jeff, I'm guessing that's because the page is layed out in XUL, and that's a XUL widget.

Comment 13

[Adam Guthrie]

*** Bug 307427 has been marked as a duplicate of this bug. ***

Comment 14

[Simon Strandman]

If it's not easy to make mozilla use the gtk theme then perhaps at least the defaults could be changed to something else? Clearlooks perhaps? That would be a lot better than now.

Comment 15

[Tuukka Tolvanen (sp3000)]

http://weblogs.mozillazine.org/roc/archives/2006/01/stormy_conditions_outlook_fair.html

Comment 16

[Oleg Romashin (:romaxa)]

Attachment: Using preferences for enabling Native Gtk theme support

This patch will allow to set using Native Gtk Themes without engine rebuilding.