Closed Bug 233105 Opened 21 years ago Closed 21 years ago

cancelling a download crashes

Categories

(SeaMonkey :: Download & File Handling, defect)

Product:
SeaMonkey
Component:
Download & File Handling
Platform:
x86
Windows 2000
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla1.7alpha

People

(Reporter: Biesinger, Assigned: Biesinger)

Details

(Keywords: crash, regression)

Attachments

(1 file)

patch
2.83 KB, patch
neil
: review+
bzbarsky
: superreview+
Details | Diff | Splinter Review 
nsDownloadManager::CancelDownload calls DownloadEnded, which removes the
downlaod from the hashtable and releases the reference... CancelDownload still
has a weak reference, uses it to access the download object, and crashes.
Attached patch patch — — Splinter Review 
additional changes: Do not use .Get in this file, only use GetWeak - saves some
codesize
Attachment #140633 - Flags: review?(neil.parkwaycc.co.uk)
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.7alpha
Severity: normal → critical
Comment on attachment 140633 [details] [diff] [review]
patch

Nice cleanup too.
Attachment #140633 - Flags: review?(neil.parkwaycc.co.uk) → review+
Attachment #140633 - Flags: superreview?(bzbarsky)
Comment on attachment 140633 [details] [diff] [review]
patch

Sure.  sr=bzbarsky
Attachment #140633 - Flags: superreview?(bzbarsky) → superreview+
checked in
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: