Closed Bug 233335 Opened 20 years ago Closed 20 years ago

Change XP_PC to XP_WIN | XP_OS2 in jssh.c

Categories

(Core :: JavaScript Engine, defect)

x86
Windows NT
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: amos, Assigned: timeless)

Details

User-Agent:       
Build Identifier: js-1.5-rc6

I believe this should be changed to XP_WIN, or eliminated entirely:

mozilla/js/src/sh/jssh.c:
     56 /* Platform-dependent stuff */
     57 #ifdef XP_PC
     58 #   define ENVIRON _environ
     59 #   define PUTENV  _putenv
     60 #   define POPEN   _popen
     61 #   define PCLOSE  _pclose
     62 #   define PLATFORM "PC"

Reproducible: Always
Steps to Reproduce:
1.
2.
3.
Assignee: general → timeless
Status: UNCONFIRMED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Summary: XP_PC still referenced in jssh.c → Change XP_PC to XP_WIN | XP_OS2 in jssh.c
No reference as to what bug/patch might have fixed this.
->WORKSFORME
Status: RESOLVED → UNCONFIRMED
Resolution: FIXED → ---
Status: UNCONFIRMED → RESOLVED
Closed: 20 years ago20 years ago
Resolution: --- → WORKSFORME
this is not part of the build, spidermonkey developers are allowed to make
changes to these files without any bug. i made the change.
Status: RESOLVED → UNCONFIRMED
Resolution: WORKSFORME → ---
Status: UNCONFIRMED → RESOLVED
Closed: 20 years ago20 years ago
Resolution: --- → FIXED
Fair enough but then say something like "Fixed by changes by Timeless" so that
this can be tracked properly in b.m.o.
You need to log in before you can comment on or make changes to this bug.