233434 - "File a bug about them" link after editing a page on Doctor doesn't work

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: General, defect)

Description

[Ian Graham]

User-Agent:       
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6) Gecko/20040113

See steps below:  

Reproducible: Always
Steps to Reproduce:
Precondition:  Make sure you are logged out from Bugzilla, so that you will need
to login again to access.

1.  Select to edit a Bugzilla.org page (e.g.
http://doctor.mozilla.org/?file=mozilla-org/html/community/developer-forums.html ) 
2. Make changes, and press the 'Review results" button
3. On the review page (http://doctor.mozilla.org/doctor.cgi) press the 
   'file a bug about them' link (as I don't have CVS permissions).
4.  YOu now see the bugzilla login page. If you login and proceed, the bug entry
fails, complaining about the data passed to it.

This bug does not occur if you are already logged into bugzilla (and can bypass
the login page).  Workaround is to just back up an try again -- it will work, as
you're now properly logged in.

Comment 1

[Dave Miller [:justdave]]

Ian: which bug form do you normally get when you file a new bug?  The guided one
that steps you through the steps to reproduce and expected results and so forth?
 If so, this is a regression from the Bugzilla upgrade.  We had a local hack to
make it work that probably got lost when we upgraded Bugzilla.

Comment 2

[Ian Graham]

I usually go in via the bugzilla helper (it's just easier/faster, and I can
always re-set things later if something is mis-assigned).  So it sounds as if
this is probably a regression. Unfortunatley adding spam bugs seemed a bad way
to test it out :-O

Comment 3

[Dave Miller [:justdave]]

Is this still broken?  I thought there was a hack put in (on the Bugzilla end)
to work around this now...

Comment 4

[Dave Miller [:justdave]]

yeah, it's still broken, and broken worse now.  Now it's broken if you're logged
in, too.  Complains that the format "default" doesn't exist.

Comment 5

[Dave Miller [:justdave]]

Attachment: force guided entry hack

Here's the original patch that forces the guided bug entry on people that don't
have canconfirm privs...

Comment 6

[Dave Miller [:justdave]]

Which is supposed to allow it to override the guided mode with the normal one if
you pass &format=__default__

However, it's now generating an error that "default" doesn't exist, and I don't
know why.  Can anyone help? :)

Comment 7

[Bryan]

Hi,
Can we leave it the way it is?
I like the Advanced form better.
It works for me.

Comment 8

[Teemu Mannermaa (:wicked)]

*** Bug 274898 has been marked as a duplicate of this bug. ***

Comment 9

[Dave Miller [:justdave]]

*** Bug 278084 has been marked as a duplicate of this bug. ***

Comment 10

[Teemu Mannermaa (:wicked)]

Attachment: Fixed force guided entry hack

Problem was that GerFormat() uses CGI methods to retrieve CGI parameters and
your hack uses and modifies only the deprecated %FORM hash. This new patch uses
CGI methods. I briefly tested it locally and it seems to do the trick.

Comment 11

[Dave Miller [:justdave]]

Thanks, Teemu!

This has been applied to b.m.o, and it seems to work!

This should also force folks without canconfirm into the guided entry page as well.

Comment 12

[Dave Miller [:justdave]]

*** Bug 274466 has been marked as a duplicate of this bug. ***