233529 - Download manager not closeable with escape key

Status: RESOLVED DUPLICATE of bug 228699

(Toolkit :: Downloads API, defect)

Description

[Tibor Csögör]

User-Agent:       
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040207 Firefox/0.8

The download manager window is not cloesable by pressing the escape key (ESC).
As other dialogs such as Page Info have this behaviour, this should be the case
for the download manager, too.

Reproducible: Always
Steps to Reproduce:
1. press CTRL+E
2. press ESC


Actual Results:  
nothin'

Expected Results:  
The download manager window should be closed.

Comment 1

[Tibor Csögör]

Attachment: adds keycode for ESC to close downloads window

Comment 2

[Ali Ebrahim]

taking qa

Comment 3

[Ali Ebrahim]

*** Bug 249553 has been marked as a duplicate of this bug. ***

Comment 4

[Steffen Wilberg]

Calling window.close() is wrong. Look a few lines up, at key id="key_close"
oncommand="closeWindow(true);".
http://lxr.mozilla.org/aviarybranch/source/toolkit/content/globalOverlay.js#1

I'll add ESC to my patch in bug 228699.

*** This bug has been marked as a duplicate of 228699 ***