233759 - Resizing add Bookmarks with tree view open begins to expand empty portion of dialog

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P3)

Description

[Will Budreau]

User-Agent:       
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6) Gecko/20040206 Firefox/0.8

Resizing the "Add Bookmarks" dialog to see the full tree only works correctly
when growing the widnow up to 25 displayed lines of the tree. After that point,
both the tree pane and the space immediately above it seem to grow equally,
making poor use of screen real estate.

Reproducible: Always
Steps to Reproduce:
1. Press ^-d
2. Click on down arrow "Show all the bookmarks folders"
3. Resize the window to the full scren size

Actual Results:  
The tree table size was the only one that changed until 25 rows of bookmarks
were shown, and then a blank part of the window began to expand as well.

Expected Results:  
Only the tree table pane should expand, because that's the only one that adds
information.

If I didn't have many nested bookmarks folders this probably wouldn't be very
annnoying.

Comment 1

[Will Budreau]

Attachment: Screenshot where area above tree pane has stretched too far

Comment 2

[PikeUK]

Yep same here and I can't find a duplicate. It's a trivial fix, just remove
flex="1" from the grid element in addBookmark2.xul, since that part shouldn't
stretch.

Comment 3

[Thomas Stache]

I see this also on Windows 2000, OS should be changed to ALL.

Comment 4

[PikeUK]

Confirming

Comment 5

[Ali Ebrahim]

It appears that mconnor wants to take this bug. So we'll let him have it. :)

Comment 6

[Mike Connor [:mconnor]]

not a blocker for 0.9

Comment 7

[Jeff Walden [:Waldo]]

*** Bug 242851 has been marked as a duplicate of this bug. ***

Comment 8

[Mike Connor [:mconnor]]

Attachment: trivial bug, trivial fix

Comment 9

[Steffen Wilberg]

simple patch is ready. blocking0.9?
Do you need review for this, Mike?

Comment 10

[Mike Connor [:mconnor]]

not really, no.  its still not a blocker, but I'll land it if I get a chance to.

Comment 11

[José Jeria]

*** Bug 247380 has been marked as a duplicate of this bug. ***

Comment 12

[Francois Ingelrest]

It's not a blocker, but it's esthetically awful. Hope it will be patched one day ;)

Comment 13

[Mike Connor [:mconnor]]

fixed branch and trunk

Comment 14

[Fareed Rizkalla]

i still experience the same thing on 0.9.2

Comment 15

[Francois Ingelrest]

Update to the latest nigthly. I'm using 20040712 Firefox/0.9.1+ and it is indeed
fixed. Thanks Mike Connor.

Comment 16

[José Jeria]

*** Bug 252820 has been marked as a duplicate of this bug. ***

Comment 17

[Nicholas Shewmaker]

I upgraded from 0.9 to 0.9.3 and I see this still.

Comment 18

[Steffen Wilberg]

> I upgraded from 0.9 to 0.9.3 and I see this still.
Then upgrade to Firefox Preview Release:
http://www.mozilla.org/products/firefox/

Comment 19

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change