234959 - SVG GDIPlus String bustage

Status: VERIFIED FIXED

(Core :: SVG, defect)

Description

[Bob Clary [:bc] (inactive)]

With Darin's string landing this busted. 

mozilla/layout/svg/renderer/src/gdiplus/nsSVGGDIPlusGlyphMetrics.cpp(509) 
: error C2665: 'ToLowerCase'
: none of the 3 overloads can convert parameter 1 from type 'class nsAutoString'

Comment 1

[Bob Clary [:bc] (inactive)]

Attachment: patch v0

Darin and Boris helped with the patch but are not responsible for any errors.

Comment 2

[Boris Zbarsky [:bzbarsky]]

you shouldn't need the LOCAL_INCLUDES change, I would think.....

Comment 3

[Bob Clary [:bc] (inactive)]

I tried it with just the change to the REQUIRES, but it couldn't find the
header. I don't know if this is the right way to fix it, but it built. ;-)

Comment 4

[Boris Zbarsky [:bzbarsky]]

Oh, hmm... what if you use "unicharutil" instead of "impl" in REQUIRES?  It
looks like those are separate modules..

Comment 5

[Boris Zbarsky [:bzbarsky]]

er, instead of "intl"

Comment 6

[Bob Clary [:bc] (inactive)]

Attachment: v1

patch v1 add unicharutil to REQUIRES instead of intl and don't mess with
LOCAL_INCLUDES builds depends fine for me.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 141782 [details] [diff] [review]
v1

sr=bzbarsky.  ;)

Comment 8

[Darin Fisher]

r=darin if that helps.

Comment 9

[Boris Zbarsky [:bzbarsky]]

I've gone ahead and checked that patch in.  Thanks for doing this, bc!

Comment 10

[Bob Clary [:bc] (inactive)]

verified.