235629 - thunderbird does not show xhtml attachments inline

Status: NEW

(MailNews Core :: MIME, defect)

Description

[Darin Fisher]

Thunderbird does not show xhtml attachments inline.

I'm using the Linux Thunderbird 0.5 (20040208) build.

It seems like Thunderbird should be able to render xhtml attachments inline.

Comment 1

[Scott MacGregor]

i'm not sure where we decide if a part is inline or not. it's probably in
libmime hard coded as text/* and image/* or something along those lines....

what's the content type for xhtml files?

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

application/xhtml+xml

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

application/xml would be a valid content type as well, I think... as well as
text/xml.

Comment 4

[Scott MacGregor]

Attachment: patch to show application/xhtml as inline content

Comment 5

[Scott MacGregor]

this stuff can go into the 1.8 trunk

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Might it be worth following the pref stored in the html_as variable?

Comment 7

[Scott MacGregor]

not a .8 stopper. I may not have time to bounce back to this before 1.0

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Maybe this should use nsIWebNavigationInfo (see bug 283125) so that this code
doesn't have to be updated every time we add support for a new MIME type?  (That
said, it does need to restrict things a bit, e.g., not using plugins.)

Comment 9

[Christian Schmidt]

Some findings:
Changing mailnews/mime/mimei.cpp is not enough. "text/html" and TEXT_HTML are treated specially in several places in mailnews/mime/*.

A MIME part whose Content-Type is not one of the currently supported ("text/html", "multipart/*" etc.) shows up as an attachment. 

application/xhtml+xml is currently parsed as HTML tag soup rather than XML.

Comment 10

[Frédéric Wang (:fredw)]

(In reply to comment #9)
> Some findings:
> Changing mailnews/mime/mimei.cpp is not enough. "text/html" and TEXT_HTML are
> treated specially in several places in mailnews/mime/*.
> 
> A MIME part whose Content-Type is not one of the currently supported
> ("text/html", "multipart/*" etc.) shows up as an attachment. 
> 
> application/xhtml+xml is currently parsed as HTML tag soup rather than XML.

Yes, changing mailnews/mime/mimei.cpp makes application/xhtml+xml attachments display inline but they are still loaded with the HTML parser.
I'm just wondering... isn't libmime simply splitting the different parts of a message? So we need to indicate elsewhere in mail/ or mailnews/ that the file has to be loaded as application/xhtml+xml?