Closed
Bug 236612
Opened 20 years ago
Closed 20 years ago
Kill nsGenericContainerElement
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
People
(Reporter: sicking, Assigned: sicking)
Details
Attachments
(1 file)
|
37.63 KB,
patch
|
jst
:
review+
jst
:
superreview+
|
Details | Diff | Splinter Review |
There is no reason to keep it around any more. SVG can just do what HTML already does and override the functions that it needs to override. If bug 198533 requires some sort of special baseclass we'll just create that then. That separation will probably look very different then the nsGenericContainerElement/nsGenericElement separation does anyway. Patch comming up.
|
Assignee | |
Comment 1•20 years ago
|
||
cc'ing people that might be interested to know this is happening.
|
|
Assignee | |
Comment 2•20 years ago
|
||
The patch is very strait forward. The only real codechange is that i inlined the ListAttributes function into List.
Assignee: general → bugmail
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•20 years ago
|
Attachment #143053 -
Flags: superreview?(jst)
Attachment #143053 -
Flags: review?(jst)
|
||
Comment 3•20 years ago
|
||
Comment on attachment 143053 [details] [diff] [review] patch to fix r+sr=jst
Attachment #143053 -
Flags: superreview?(jst)
Attachment #143053 -
Flags: superreview+
Attachment #143053 -
Flags: review?(jst)
Attachment #143053 -
Flags: review+
|
|
Assignee | |
Comment 4•20 years ago
|
||
Checked in. Thanks for the quick review.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•