236893 - A more useful set of context menu options for the toolbars

Status: RESOLVED DUPLICATE of bug 880164

(Firefox :: Toolbars and Customization, enhancement, P3)

Description

[Ben Goodger (use ben at mozilla dot org for email)]

Per the leading authority in customizable toolbars, context menus for
customizable items should read:

    Icons and Text
(*) Icons 
    Text
 ------------------
[x] Use Small Icons
 ------------------
    Remove Item
    Customize Toolbar...

Comment 1

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: partial work

this doesn't work properly yet, specifically:

- hitting "use small icons" twice in a row does not restore state
- remove item is not implemented yet
- customize... is mysteriously disabled sometimes.

Comment 2

[Michiel van Leeuwen (email: mvl+moz@)]

I whish those functions would be somewhere where they can be shared between
toolkit apps, instead of copied.
And the same for the menu items.

Comment 3

[Mike Connor [:mconnor]]

Attachment: works correctly, only tested on Mac, doesn't add Remove Item (yet)

this hits a weird crash, to be filed separately, in re-resolving style...

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I tried to compile a debug build from cvs today on Mac OS but Firefox crashes before the profile manager comes up. I have to wait for a working version and will try it again within the next days.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Mike, after bug 386642 is fixed now I wanted to test your patch but it is bitrotted meanwhile. Can you supply an updated version?

Comment 6

[Mike Connor [:mconnor]]

Attachment: unbitrotted

I don't know if I want Remove Item, tbh.  Let's do this for now and see how it feels.  Figured I should finally unbitrot this...

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Beltzner, could you please have a look at mconnors patch?

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 337805 [details] [diff] [review]
unbitrotted

This bit rotted. Noticed a minor bug in onViewToolbarsPopupShowing:

+  if (!toolboxMode)
+    toolbox.getAttribute("defaultmode");

Also don't really like the code duplication, isn't there a way to avoid that?

Comment 9

[Matthew N. [:MattN]]

The Firefox 29 customization improvements (part of "Australis") added the move/remove context menu items.