Closed Bug 237078 Opened 20 years ago Closed 20 years ago

Remove table background quirk

Categories

(Core :: Layout: Tables, defect)

Product:
Core
Component:
Layout: Tables
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: fantasai.bugs, Assigned: fantasai.bugs)

References

Details

Attachments

(2 files, 2 obsolete files)

new patch
17.83 KB, patch
Details | Diff | Splinter Review
new diff (ignoring whitespace)
20.39 KB, text/plain
Details 
Just to reword the summary,

  Remove quirky table background painting for 1.8a and back out the change in a
  later release if it causes problems.
Depends on: 4510
*** Bug 239207 has been marked as a duplicate of this bug. ***
Attached patch patch (obsolete) — — Splinter Review 

    
    

    
  

      
      
      
      

        Attached file
          
        diff (ignoring whitespace) (obsolete)
        — 
      

    


  

    
  

        Attachment #146239 -
        Flags: superreview?(dbaron)

        Attachment #146239 -
        Flags: review?(bernd.mielke)

    
    

    
  
Comment on attachment 146239 [details] [diff] [review]
patch

sr=dbaron, although I think it would be slightly cleaner to make aDeflate an
|const nsMargin&| and change nsTableFrame::Paint so the
      nsMargin deflate(0,0,0,0);
and the call to PaintTable were outside the quirks mode if/else (with no else
at all anymore).

        Attachment #146239 -
        Flags: superreview?(dbaron) → superreview+

    
  

        Attachment #146239 -
        Flags: review?(bernd.mielke) → review?(bernd_mozilla)

    
    

    
  
Comment on attachment 146239 [details] [diff] [review]
patch

with those changes that david asked for

        Attachment #146239 -
        Flags: review?(bernd_mozilla) → review+

    
    

    
  

      
      
      
      

        Attached patch
          
          
        new patch
        — 
          — Splinter Review
      

    


  

        Attachment #146239 -
        Attachment is obsolete: true

    
    

    
  


  

    
  

        Attachment #146240 -
        Attachment is obsolete: true

    
    

    
  
It would be cool if attachment 146358 [details] [diff] [review] wouldn't crash the regression tests at
layout/html/tests/dom/deleteCol3.html

    
  
Depends on: 240854

    
    

    
  
fix checked in
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: