Closed Bug 237231 Opened 20 years ago Closed 20 years ago

make xpistub interface description and implementation agree

Categories

(Core Graveyard :: Installer: XPInstall Engine, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ajschult784, Assigned: ajschult784)

References

()

Details

Attachments

(2 files, 1 obsolete file)

xpistub.h says that XPI_Init
1. takes parameters aProgramDir, startCB, progressCB and finalCB
2. aProgramDir: "...If NULL default will be used -- the location of the calling
executable."

in xpistub.c, XPI_Init
1. takes parameters aProgramDir, aLogName and progressCB
2. if aProgramDir is NULL, XPI_Init crashes
http://lxr.mozilla.org/mozilla/source/xpinstall/stub/xpistub.cpp#197

for #1, the interface description should be updated.
I'd like to actually implement #2 for use in bug 77365
Attached patch patch (obsolete) — Splinter Review
cleanup xpistub.h and implement handling NULL aProgramDir parameter.
Attachment #143871 - Flags: review?(bsmedberg)
Comment on attachment 143871 [details] [diff] [review]
patch

r=me
please remove the XP_MAC cruft in this file, while you're touching it (we no
longer support MacOS9).
Attachment #143871 - Flags: review?(bsmedberg) → review+
Attachment #143871 - Attachment is obsolete: true
Comment on attachment 144745 [details] [diff] [review]
patch + remove XP_MAC

this already has r=bsmedberg
Attachment #144745 - Flags: superreview?(dveditz+bmo)
Attachment #144745 - Flags: review+
Comment on attachment 144745 [details] [diff] [review]
patch + remove XP_MAC

Thanks!
sr=dveditz
Attachment #144745 - Flags: superreview?(dveditz) → superreview+
checked in by timeless
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: