Closed Bug 237516 Opened 20 years ago Closed 11 years ago

confusing cancellation message for tokens

Categories

(Bugzilla :: User Accounts, defect)

2.17.7
defect
Not set
minor

Tracking

()

RESOLVED FIXED
Bugzilla 5.0

People

(Reporter: timeless, Assigned: sjoshi)

References

()

Details

Attachments

(1 file)

29 A request was cancelled from [% remoteaddress %].
 30 
 31 If you did not request this, it could be either an honest
 32 mistake or someone attempting to break into your [% terms.Bugzilla %] 
account.

what does 'request' mean in this context? does it reference the act 
of cancelling the request, or the original request. if it's the original 
request, and the user took the action of cancelling the request, what value does 
the statement add?
QA Contact: mattyt-bugzilla → default-qa
Looks valid.

Could it be as simple as replacing the first 'request' by something appropriate
to the type of token?
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows NT → All
Hardware: PC → All
Assignee: myk → attach-and-request
Unrelated to attachments & requests.
Assignee: attach-and-request → user-accounts
Component: Attachments & Requests → User Accounts
Attached patch Patch-v1Splinter Review
Replaced "request" text with subject of the email to correctly identify the cancelled request.
Assignee: user-accounts → joshi_sunil
Status: NEW → ASSIGNED
Attachment #778856 - Flags: review?(dkl)
Comment on attachment 778856 [details] [diff] [review]
Patch-v1

Review of attachment 778856 [details] [diff] [review]:
-----------------------------------------------------------------

::: template/en/default/account/cancel-token.txt.tmpl
@@ +11,4 @@
>  Subject: [% PROCESS subject %]
>  X-Bugzilla-Type: admin
>  
> +A [% PROCESS subject %] from [% remoteaddress %].

We need to completely remove 'A '. We can do this on commit. r=dkl
Attachment #778856 - Flags: review?(dkl) → review+
Flags: approval?
Flags: approval? → approval+
Committing to: bzr+ssh://dlawrence%40mozilla.com@bzr.mozilla.org/bugzilla/trunk
modified template/en/default/account/cancel-token.txt.tmpl
Committed revision 8675.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Bugzilla 5.0
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: