Closed Bug 238095 Opened 20 years ago Closed 20 years ago

rework pause/resume of net installer

Categories

(SeaMonkey :: Installer, defect)

All
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.8alpha1

People

(Reporter: ajschult784, Assigned: ajschult784)

References

Details

Attachments

(1 file)

I haven't found any user-noticable symptoms of this, but the sequence of events
that happens when hitting pause/resume is:

(pause)
nsHTTPCon::Get calls DownloadCB
DownloadCB flushes events before returning (gtk notices the click on "pause")
DLPause fires off another event loop
(resume)
DLResume ends the event loop and starts PerformInstall()

unfortunately, calling gtk_main_quit in DLResume has no imeadiate effect because
it calls PerformInstall before retruning.

So, pause/resume creates a paused orphan download.

I have a patch for this, but I'm still testing fringe cases.
Blocks: 237792
Attached patch patchSplinter Review
the pause event loop now starts in ::Next, and calls PerformInstall from there
if the user resumes.

with this pause/resume/cancel/connection dropped works in normal/auto mode
and this doesn't break anything I've noticed, but it prevents me from fixing bug
237792
Summary: tweak pause/resume of net installer → rework pause/resume of net installer
Target Milestone: --- → mozilla1.8alpha
Attachment #144432 - Flags: review?(dveditz+bmo)
Comment on attachment 144432 [details] [diff] [review]
patch

r=dveditz
Attachment #144432 - Flags: review?(dveditz) → review+
Attachment #144432 - Flags: superreview?(bryner)
Attachment #144432 - Flags: superreview?(bryner) → superreview+
fixed
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: