238303 - warnings about conversion from 'int32' to 'char' and 'jschar'

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[timeless]

r:/mozilla\js\src\jsdtoa.c(2683) : warning C4244: '=' : conversion from 'int32' 
to 'char', possible loss of data
r:/mozilla\js\src\jsregexp.c(275) : warning C4244: 'initializing' : conversion 
from 'int32' to 'jschar', possible loss of data
r:/mozilla\js\src\jsregexp.c(284) : warning C4244: 'initializing' : conversion 
from 'int32' to 'jschar', possible loss of data
r:/mozilla\js\src\jsstr.c(743) : warning C4244: '=' : conversion from 'int32' 
to 'jschar', possible loss of data
r:/mozilla\js\src\jsstr.c(790) : warning C4244: '=' : conversion from 'int32' 
to 'jschar', possible loss of data

Comment 1

[timeless]

Attachment: cast dig (as done a few lines above) and cast back to jschar for JS_TOUPPER/JS_TOLOWER

Comment 2

[timeless]

Comment on attachment 144514 [details] [diff] [review]
cast dig (as done a few lines above) and cast back to jschar for JS_TOUPPER/JS_TOLOWER

i don't think i really need reviews for these changes, but the tree is frozen,
so a review won't hurt.

Comment 3

[Brendan Eich [:brendan]]

Attachment: I checked this in

80th column preservation in jsstr.h.

/be

Comment 4

[Brendan Eich [:brendan]]

.