238474 - add ctrl++/ctrl+- in View Source doesnt work with all keys

Status: VERIFIED FIXED

(Firefox :: General, enhancement)

Description

[José Jeria]

This bug is a spinoff to bug 215463. 

Font size can be resized, but not with the +/= key next to backspace

Comment 1

[R.J. Keller]

Neil: Do you know if this could be a bustage in some other component? It sounds
strange how the minus key works on the numeral keypad and the main keyboard
while the plus key doesn't.

Comment 2

[[e-mail]]

Sorry, no point asking me about FF's zoom implementation...

Comment 3

[Mike Connor [:mconnor]]

http://lxr.mozilla.org/mozilla/source/browser/base/locale/browser.dtd#258
http://lxr.mozilla.org/mozilla/source/browser/base/content/browser-sets.inc#271

lxr has the answers

Comment 4

[R.J. Keller]

Attachment: Patch

Thanks for that lxr entry, mconnor! For some reason I never noticed that I
wasn't holding down the shift key while holding ctrl :p.

This patch should fix that problem now.

Comment 5

[Mike Connor [:mconnor]]

Comment on attachment 145397 [details] [diff] [review]
Patch

exactly, r=[e-mail]

Comment 6

[R.J. Keller]

Fix checked in.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

This is still broken in Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8a)
Gecko/20040512 Firefox/0.8.0+

I'm not able to increase the font size with the '+' key on the main keyboard. I
always filed bug 240955 for that problem.

-> Reopen because bug 240955 blocks this one.

Comment 8

[R.J. Keller]

Henrick: I cannot reproduce that problem. This bug is fixed on Mozilla/5.0
(Windows; U; Windows NT 5.1; en-US; rv:1.8a) Gecko/20040513 Firefox/0.8.0+

Resolving bug.

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to comment #8)
> Henrick: I cannot reproduce that problem. This bug is fixed on Mozilla/5.0
> (Windows; U; Windows NT 5.1; en-US; rv:1.8a) Gecko/20040513 Firefox/0.8.0+
> 
> Resolving bug.

Why you are mark this bug as resolved again? This bug isn't fixed! You can't
reproduce it because you doesn't use the german keyboard layout. An ongoing
discussion you will find in bug 244334.

Comment 10

[José Jeria]

I use a swedish keyboard and CTRL++ doesnt work, CTRL+0 does though.

Comment 11

[Mike Connor [:mconnor]]

if various language keyboards don't work (after the bug 244334 checkin) please
file appropriate bugs, don't reopen this.

Comment 12

[Peter van der Woude [:Peter6]]

UK keyboard see bug 253916