Closed Bug 238498 Opened 20 years ago Closed 20 years ago

tree.css in Modern theme uses system colours

Categories

(Core :: XUL, defect)

Product:
Core
Component:
XUL
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: neil, Assigned: neil)

References

Details

(Keywords: access, regression)

Attachments

(1 file)

Proposed patch
1.44 KB, patch
jag+mozilla
: review+
jag+mozilla
: superreview+
chofmann
: approval1.7+
Details | Diff | Splinter Review 
Modern theme should not use any system colours at all, but the patch to bug
236973 checked two in. CC'ing the people alleged to have given review.
No longer depends on: 236973
Depends on: 236973
Attached patch Proposed patch — — Splinter Review 
My understanding is that alternating colours should not apply to selected rows.
Assignee: varga → neil.parkwaycc.co.uk
Status: NEW → ASSIGNED
Attachment #144841 - Flags: review?(caillon)
r=varga, but could you optimise classic too?
Comment on attachment 144841 [details] [diff] [review]
Proposed patch

ok, I was told that classic is tricky and it has its own bug
Attachment #144841 - Flags: review?(caillon) → review+
Attachment #144841 - Flags: superreview?(jag)
Attachment #144841 - Flags: review?
Attachment #144841 - Flags: review+
Comment on attachment 144841 [details] [diff] [review]
Proposed patch

sr=jag. Oops, missed this.
Attachment #144841 - Flags: superreview?(jag)
Attachment #144841 - Flags: superreview+
Attachment #144841 - Flags: review?
Attachment #144841 - Flags: review+
Comment on attachment 144841 [details] [diff] [review]
Proposed patch

Fix for one regression from bug 236973 (assuming you don't simply back that bug
out on the branch).
Attachment #144841 - Flags: approval1.7?
Comment on attachment 144841 [details] [diff] [review]
Proposed patch

a=chofmann for 1.7
Attachment #144841 - Flags: approval1.7? → approval1.7+
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Component: XP Toolkit/Widgets: Trees → XUL
QA Contact: shrir → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: