238665 - "change anything on the selected" is awkward in "bugs_not_changed" error

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect)

Description

[timeless]

123   [% ELSIF error == "bugs_not_changed" %]
124     [% title = BLOCK %][% terms.Bugs %] Not Changed[% END %]
125     Um, you apparently did not change anything on the selected [% terms.bugs %].

change "on" to "in"

Comment 1

[Christopher Nehren]

Attachment: Patch on => in.

Comment 2

[Christopher Nehren]

Attachment: Oops. Submitting irrelevant patch hunks is bad.

Comment 3

[Christian Reis]

Comment on attachment 144902 [details] [diff] [review]
Oops. Submitting irrelevant patch hunks is bad.

Doh.

Comment 4

[Dave Miller [:justdave]]

Hmmm, this sounds just as awkward as the original one to me...  opinions anyone?

Comment 5

[Gervase Markham [:gerv]]

"Um, you didn't change any fields, so there's nothing for me to do."?

Gerv

Comment 6

[Dave Miller [:justdave]]

Comment on attachment 144902 [details] [diff] [review]
Oops. Submitting irrelevant patch hunks is bad.

I don't think either sounds any better than the other.	Gerv's sounds a little
better to me.  If we have to change this as all, lets go with something along
the lines of what he suggested.

Comment 7

[Shane H. W. Travis]

Of more interest, perhaps, is the fact that I cannot raise this error. I assume 
from looking at process_bug.cgi (the only place where it is called), and from 
context, that it's supposed to pop up if you hit 'commit' without changing 
anything on a bug... but that's not what happens. I get a 'Changes Submitted' 
screen that sends mail to nobody, and which adds nothing to the Bug Activity 
screen.

Right now, this may as well be removed as modified, as I cannot generate this 
error message on 2.16.7, 2.18, or the tip.

Comment 8

[Frédéric Buclin]

travis, you need to change several bugs at once. Select some of them and do
nothing else except hitting the 'Commit' button. The message error then appear. :)

Comment 9

[Shane H. W. Travis]

(In reply to comment #8)
> travis, you need to change several bugs at once. Select some of them and do
> nothing else except hitting the 'Commit' button.

Doing that raises the no_bugs_chosen error message; this bug is about the 
bugs_not_changed error message. 

Comment 10

[Shane H. W. Travis]

whoops... I missed the 'select some of them' part. I just clicked 'commit' 
after selecting none of them, thus raising the wrong error.

Patch to follow.

Comment 11

[Shane H. W. Travis]

Attachment: Code patch for tip

Comment 12

[Shane H. W. Travis]

Attachment: Code patch for tip, take 2

All that, and I don't even change 'on' to 'in'. :)

Comment 13

[Shane H. W. Travis]

Checking in template/en/default/global/user-error.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/user-
error.html.tmpl,v  <--  user-error.html.tmpl
new revision: 1.93; previous revision: 1.92
done