239348 - [patch] Enable various encoding at Toolbar google search for Customizing Search Engines

Status: RESOLVED INVALID

(Camino Graveyard :: Toolbars & Menus, defect)

Description

[waverider]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7b) Gecko/20040331 Camino/0.7+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7b) Gecko/20040331 Camino/0.7+

http://www.mozilla.org/products/camino/features/searchCustomization.html

Encoding search-string to multibyte encoding (Shift-JIS, EUC-JP, UTF-8, etc) is
necessary to search with various language.
at present, Camino always encode search-string to UTF-8 and send it.
But almost search services by CGI require same encoding of search page.
If charset of search page = "EUC-JP" , we should encode search-string to "EUC-JP".
we should change encoding each search site for Customizing Search Engines.

Reproducible: Always
Steps to Reproduce:

Comment 1

[waverider]

Attachment: simple patch with sample of SearchURLList.plist.

Change SearchURLList.plist:
Set NSDictionary to encoding Number and URL.
encoding Number is enum kCFStringEncoding at Core foundation.

Comment 2

[Eiichi]

I'm using Google Japan as default ToolBar Search with SearchURLList.plist
settings as below;

<key>Google</key>
<string>http://www.google.co.jp/search?q=%s&amp;hl=ja&amp;ie=UTF-8&amp;oe=SHIFT_JIS&amp;lr=lang_ja&amp;num=100</string>

And it seems for me there are no problems.
Are there any differences of results between encoding UTF-8 and encoding SHIFT_JIS?

Comment 3

[Eiichi]

I'm sorry, I misunderstood.
Yahoo Japan can't find out the corresponding strings of UTF-8.

Comment 4

[waverider]

This bug is not RESOLVED and not INVALID.
Please read my first comment again.

Camino always encode search-string to escaped UTF-8.
Fortunately Google have option to enable escaped UTF-8 ( "ie=UTF-8" ), 
but almost search engine don't have such option and require various charset.
( Alphabet are assigned same block in most charset and trouble has not happenned. )

If we use only Google, no problem.
but when we customize search engine, we should change charset be suitable for
each search engine.