Closed
Bug 240473
Opened 20 years ago
Closed 19 years ago
Tell config tools where .idl files are installed
Categories
(SeaMonkey :: Build Config, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: braden, Assigned: chpe)
Details
(Keywords: fixed-aviary1.0.8, fixed1.7.6)
Attachments
(2 files)
492 bytes,
patch
|
benjamin
:
review+
dveditz
:
approval-aviary1.0.8+
mkaply
:
approval1.7.6+
|
Details | Diff | Splinter Review |
1.10 KB,
patch
|
benjamin
:
review+
dveditz
:
approval-aviary1.0.8+
mkaply
:
approval1.7.6+
|
Details | Diff | Splinter Review |
It would be nice if there were a means of determining where Mozilla's .idl files are installed. I'm thinking simply an "idldir" variable in mozilla-xpcom.pc should be sufficient.
mozilla-config has --idlflags although right now the proper value doesn't get substituted into the file.
Attachment #146470 -
Flags: review?(bsmedberg)
Updated•20 years ago
|
Attachment #146470 -
Flags: review?(bsmedberg) → review+
Attachment #146470 -
Attachment description: Fix mozilla-config → Fix mozilla-config (checked in)
Updated•20 years ago
|
Product: Browser → Seamonkey
Attachment #172356 -
Flags: review?(bsmedberg)
seawood's patch does not appear to have been checked in on the 1.7 branch. I think it really ought to be (along with mine).
Flags: blocking1.7.6?
Attachment #146470 -
Flags: approval1.7.6?
Attachment #172356 -
Flags: approval1.7.6?
Comment 5•20 years ago
|
||
Comment on attachment 146470 [details] [diff] [review] Fix mozilla-config (checked in) a=mkaply for 1.7.6
Attachment #146470 -
Flags: approval1.7.6? → approval1.7.6+
Updated•20 years ago
|
Attachment #172356 -
Flags: approval1.7.6?
Updated•20 years ago
|
Keywords: fixed1.7.6
Removed keyword fixed1.7.6. The remaining patch to fix (on 1.7.6 and otherwise) this is still awaiting review.
Keywords: fixed1.7.6
Comment 7•19 years ago
|
||
Is "idldir" a standard of some sort?
Of *some* sort? I suppose... it's the variable name for that directory used by mozilla-config. So it's consistent with the existing convention.
Updated•19 years ago
|
Attachment #172356 -
Flags: review?(benjamin) → review+
Attachment #172356 -
Flags: approval1.7.6?
Comment 9•19 years ago
|
||
Comment on attachment 172356 [details] [diff] [review] Patch for pkg-config metadata a=mkaply
Attachment #172356 -
Flags: approval1.7.6? → approval1.7.6+
Comment 10•19 years ago
|
||
Comment on attachment 172356 [details] [diff] [review] Patch for pkg-config metadata mozilla/build/unix/Makefile.in 1.23 mozilla/build/unix/mozilla-xpcom.pc.in 1.3 mozilla/build/unix/Makefile.in 1.21.2.1 mozilla/build/unix/mozilla-xpcom.pc.in 1.1.102.2
Attachment #172356 -
Attachment is obsolete: true
Assignee | ||
Comment 11•19 years ago
|
||
Comment on attachment 146470 [details] [diff] [review] Fix mozilla-config (checked in) This was never checked in to aviary branch. It's an important fix, and has no risk.
Attachment #146470 -
Flags: approval-aviary1.0.4?
Reporter | ||
Comment 12•19 years ago
|
||
Christian: Is there a reason you didn't flag the pkg-config metadata fix for Aviary approval as well?
Reporter | ||
Comment 13•19 years ago
|
||
And what about bug 279427?
Comment 14•19 years ago
|
||
Drivers are looking at 1.0.5 approval requests and this one has a bunch of unanswered questions: Do both patches need approval? what about bug 279427 mentioned by Braden? Why did timeless mark the second attachment obsolete, was only the first checked in?
Assignee | ||
Comment 15•19 years ago
|
||
Sorry for not responding earlier; this bug had somehow fallen off of my radar. (In reply to comment #12) > Christian: Is there a reason you didn't flag the pkg-config metadata fix for > Aviary approval as well? The mozilla-config.in patch is a bugfix, while the other patch is a featurelet; so I only requested a? for the first patch. But since the other patch is on 1.7 branch too, I guess it makes sense to request a? for the pkg-config patch too. I'll do that in a minute. (In reply to comment #13) > And what about bug 279427? Yeah, that should go on aviary too, for parity with 1.7 branch. I'll request a? there. (In reply to comment #14) > Do both patches need approval? Yes. > what about bug 279427 mentioned by Braden? See above. > Why did timeless mark the second attachment obsolete, was only the first checked in? Don't know why it was marked obsolete; both patches are present on trunk and 1.7 branch.
Assignee | ||
Comment 16•19 years ago
|
||
Comment on attachment 172356 [details] [diff] [review] Patch for pkg-config metadata Requesting a1.0.5 for parity with 1.7 branch.
Attachment #172356 -
Flags: approval-aviary1.0.5?
Comment 17•19 years ago
|
||
Comment on attachment 172356 [details] [diff] [review] Patch for pkg-config metadata not obsolete -- good patch we'd want if we port to aviary or other branch
Attachment #172356 -
Attachment is obsolete: false
Comment 18•19 years ago
|
||
> Why did timeless mark the second attachment obsolete, was only the first checked in? Timeless marks checked in patches as obsolete. See bug 115514#c5 .
Comment 19•19 years ago
|
||
Comment on attachment 172356 [details] [diff] [review] Patch for pkg-config metadata 1.0.5 has already shipped; removing approval request.
Attachment #172356 -
Flags: approval-aviary1.0.5?
Updated•19 years ago
|
Attachment #146470 -
Flags: approval-aviary1.0.5?
Assignee | ||
Comment 20•19 years ago
|
||
Comment on attachment 146470 [details] [diff] [review] Fix mozilla-config (checked in) Renominating for next round of branch release
Attachment #146470 -
Flags: approval-aviary1.0.7?
Assignee | ||
Comment 21•19 years ago
|
||
Comment on attachment 172356 [details] [diff] [review] Patch for pkg-config metadata Renominating for next round of branch release.
Attachment #172356 -
Flags: approval-aviary1.0.7?
Comment 22•19 years ago
|
||
Comment on attachment 146470 [details] [diff] [review] Fix mozilla-config (checked in) a=dveditz for drivers
Attachment #146470 -
Flags: approval-aviary1.0.8? → approval-aviary1.0.8+
Comment 23•19 years ago
|
||
Comment on attachment 172356 [details] [diff] [review] Patch for pkg-config metadata a=dveditz for drivers
Attachment #172356 -
Flags: approval-aviary1.0.8? → approval-aviary1.0.8+
Reporter | ||
Comment 24•19 years ago
|
||
If someone thought this bug needed to be fixed on another branch, why wasn't it reopened?
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Reporter | ||
Comment 25•19 years ago
|
||
chpe: is there a reason you didn't also renominate bug 279427, or was that just an oversight?
Comment 26•19 years ago
|
||
Braden, bugs are marked FIXED when they are fixed on trunk. Branch landings are managed with keywords.
Status: NEW → RESOLVED
Closed: 19 years ago → 19 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 27•19 years ago
|
||
I see. Someone who cares about said branch is welcome to pick this up.
Updated•19 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 28•19 years ago
|
||
Needs to land ASAP if this is still needed in the aviary101 branch
Assignee: nobody → chpe
Status: REOPENED → NEW
Updated•19 years ago
|
Status: NEW → RESOLVED
Closed: 19 years ago → 19 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 29•19 years ago
|
||
(In reply to comment #25) > chpe: is there a reason you didn't also renominate bug 279427, or was that just > an oversight? I forgot to do that, yes.
Comment 30•19 years ago
|
||
Comment on attachment 172356 [details] [diff] [review] Patch for pkg-config metadata mozilla/build/unix/mozilla-xpcom.pc.in 1.1.106.1.2.1 AVIARY_1_0_1_20050124_BRANCH
Updated•19 years ago
|
Keywords: fixed-aviary1.0.8
You need to log in
before you can comment on or make changes to this bug.
Description
•