24052 - Save/Saving switches on the execute bit.

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P3)

Description

[chimera]

When saving with the Editor under Build ID 2000011018. The file saved would have
the executable/execute bit turned on. ie instead of the file's permission being
644, they were 755 (with a umask of 022). This would only affect Unix-like
filesystems.

Comment 1

[rubydoo123]

going to shaver for tracking

Comment 2

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

(How did [e-mail] get in the bugzilla database again?)

What am I tracking?  I'm lost -- why is this my bug?

Comment 3

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Beppe?

Comment 4

[rubydoo123]

because you were the unix god around here -- will assign it to kin to see what 
can be done

Comment 5

[J. R. Petrus]

Attachment: A patch to fix bug #24052.

Comment 6

[J. R. Petrus]

About the above patch:
Works in Linux so that default permissions are 655 (or whatever you want them to
be).  The problem was that the wrong nsOuputFileStream constructor was used and
defaulting to 700 in src/mozilla/layout/base/src/nsDocument.cpp.

Comment 7

[J. R. Petrus]

Attachment: Path that does 644, not 655.

Comment 8

[dahd]

Attachment: This *finally* patches mozilla/layout/base/src/nsDocument.cpp to fix this bug and default the permissions to 644 (and not 700 or 655).

Comment 9

[kinmoz]

Accepting bug.

Comment 10

[rubydoo123]

asking Kin to review the patch so mozilla folks can approve for checkin

Comment 11

[kinmoz]

Attachment: Patch as a one line modification.

Comment 12

[kinmoz]

Waiting for permission from [e-mail] or [e-mail] to check
in the fix.

Comment 13

[kinmoz]

[e-mail] changed the default permissions to 0666 so the patch is no 
longer neccessary.

    mozilla/xpcom/io/nsFileStream.cpp    revision 1.29
    mozilla/xpcom/io/nsFileStream.h      revision 1.34

a=[e-mail]

Comment 14

[kinmoz]

Marking fixed for [e-mail].

Comment 15

[sujay]

verified in 10/30 build.