241201 - Clean up some webservices code

Status: RESOLVED FIXED

(Core Graveyard :: Web Services, defect)

Description

[Peter Van der Beken [:peterv]]

Comment 1

[Peter Van der Beken [:peterv]]

Attachment: v1

Remove space after NS_IMETHODIMP, switch to nsCOMArray instead of
nsSupportsArray and nsInterfaceHashtable instead of nsSupportsHashtable, use
nsAutoPtr for mArrayInfo, use better string foo, correct anyUri to anyURI (see
http://www.w3.org/TR/2001/REC-xmlschema-2-20010502/#anyURI).

Comment 2

[Peter Van der Beken [:peterv]]

Attachment: v1 (diff -w)

Comment 3

[Johnny Stenback (:jst)]

Comment on attachment 146681 [details] [diff] [review]
v1

Very nice! r+sr=jst

Comment 4

[Ben Goodger (use ben at mozilla dot org for email)]

Erm. This patch causes the app to crash in my extension manager (not enabled
completely yet, but a use of SOAP)...

###!!! ASSERTION: nsTHashtable was not initialized properly.: 'mTable.entrySize'
, file ../../../../dist/include/xpcom\nsTHashtable.h, line 179

DecodeStructParticle (when returning complex types) calls nsSchema::AddType
which attempts to do a hash operation and fails with the following assertion
followed by a crash. 

This is blocking my 0.9 extension manager work. We need a good test suite for
web services so this sort of stuff doesn't keep breaking.

Comment 5

[Peter Van der Beken [:peterv]]

Attachment: Bustage fix

I seem to have missed some code to init the hashtables. I just checked in this
patch, it should fix that crash.

Comment 6

[Ben Goodger (use ben at mozilla dot org for email)]

Thanks for the fast turnaround!

Comment 7

[Cédric Chantepie]

Attachment: Patch for AVIARY

Modifications seem not to have been applied before aviary

Comment 8

[Harshal Pradhan]

Comment on attachment 164003 [details] [diff] [review]
Patch for AVIARY

At this stage you won't get aviary approval of anything other than small and
clear bugfixes. It is much too late for random cleanup.

Comment 9

[Cédric Chantepie]

(In reply to comment #8)
> (From update of attachment 164003 [details] [diff] [review])
> At this stage you won't get aviary approval of anything other than small and
> clear bugfixes. It is much too late for random cleanup.
> 

So is there any devel sub-branch for aviary one on which I could try to apply
this patch and on which I could get approval for ?