Closed Bug 242394 Opened 20 years ago Closed 14 years ago

make installer not leak

Categories

(SeaMonkey :: Installer, defect)

Product:
SeaMonkey
Component:
Installer
Platform:
All
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED INCOMPLETE

People

(Reporter: ajschult784, Assigned: ajschult784)

References

Details

(Keywords: memory-leak, Whiteboard: [patchlove])

Attachments

(2 files)

valgrind leak log
9.22 KB, text/plain
Details
patch
5.94 KB, patch
benjamin
: review+
dveditz
: superreview+
Details | Diff | Splinter Review 
The installer leaks quite a bit.  Most, but not all, are shutdown leaks.  I'll
attach a valgrind leak log.  Some of these would be fixed by the patch in bug
101471.
Attached file valgrind leak log — 
LEAK SUMMARY:
   definitely lost: 6902 bytes in 95 blocks.
   possibly lost:   732 bytes in 12 blocks.
   still reachable: 611930 bytes in 2365 blocks.
Depends on: 242524
Attached patch patch — — Splinter Review 
This fixes the installer leaks not fixed by the patch in bug 101741 except for
the component duplicates, which I hope to fix in bug 242524.

The leaks within gtk_init are unfixable.  The other leaks in the valgrind log
seem to be elsewhere in gecko.
Attachment #147599 - Flags: review?(bsmedberg)
QA Contact: bugzilla → agracebush
Attachment #147599 - Flags: review?(bsmedberg) → review+
Attachment #147599 - Flags: superreview?(dveditz)
Product: Browser → Seamonkey
*** Bug 333316 has been marked as a duplicate of this bug. ***
Attachment #147599 - Flags: superreview?(dveditz)
Comment on attachment 147599 [details] [diff] [review]
patch

sr=dveditz if we're still using this.
Attachment #147599 - Flags: superreview+
Status: NEW → ASSIGNED
Whiteboard: [patchlove]
QA Contact: agracebush → xpi-packages
This is on old installer, which is gone.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: