242583 - nsStringStream.cpp(270) : warning C4244: 'initializing' : conversion from 'PRInt64' to 'PRInt32', possible loss of data

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[timeless]

r:/mozilla\xpcom\io\nsStringStream.cpp(270) : warning C4244: 'initializing' :
conversion from 'PRInt64' to 'PRInt32', possible loss of data

This is because attachment 144227 [details] [diff] [review] (sr=mscott, no r=) changed the code to be broken.

attachment 144054 [details] [diff] [review] (r=darin) would have been fine.

Comment 1

[David :Bienvenu]

no, attachment 144054 [details] [diff] [review] would not have been fine:

 NS_ASSERTION(offset < 0xFFFFFFFF, "string streams only support 32 bit offsets");

would have generated a warning...

Comment 2

[Darin Fisher]

timeless: can you please explain what conditions lead to this warning?  are you
trying to use a string stream with more than 4GB of data or seek to a really
distant position in the stream?  how serious is this bug?  is anything important
affected?

Comment 3

[David :Bienvenu]

Attachment: proposed fix

Comment 4

[Darin Fisher]

Comment on attachment 147645 [details] [diff] [review]
proposed fix

r=darin

Comment 5

[timeless]

i'm just trying to build.