242752 - "System New Mail Sound" should be "System Alert Sound"

Status: RESOLVED FIXED

(Thunderbird :: Preferences, defect)

Description

[Brion Vibber]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en-us) AppleWebKit/124 (KHTML, like Gecko) Safari/125.1
Build Identifier: version 0.6 (20040502)

The default option for what new mail notification sound to play is labeled "System New Mail Sound". 
Mac OS X doesn't have a system-wide sound theme system, so what is actually played is the generic 
alert sound. The label should reflect this to avoid implying that it is distinct from the alert 
sound.

Reproducible: Always
Steps to Reproduce:
1. Open preferences

Actual Results:  
See radio button labeled:
(*) System New Mail Sound

Expected Results:  
Should see radio button labeled:
(*) System Alert Sound

Comment 1

[Jim Strickland]

Is there a reason that Thunderbird has never been set to use anything other than
the system-wide alert sound? If that is an option that is just not going to be
available, then it should be removed from the preferences altogether

Comment 2

[Matthew (lilmatt) Willis]

This is actually the case in Seamonkey as well.

I'll attach patches for Thunderbird. If we want to also put this in Seamonkey,
we can move the changes there, and not override prefs-notifications.dtd in
Thunderbird.

Comment 3

[Matthew (lilmatt) Willis]

Attachment: patch to change Mac lable to "System Alert Sound"

This patch also requires the new pref-notifications.dtd

Moved pref-notifications.dtd in from Seamonkey and added Mac-specific ENTITY.
Added #ifdef to xul to use Mac-specific label.

Comment 4

[Matthew (lilmatt) Willis]

Attachment: Moved dtd into thunderbird from seamonkey and added Mac-specific ENTITY

This is also required -- cvs add wouldn't let me add it to my local repository.

Put in 
mozilla/mail/components/prefwindow/locale/pref-notifications.dtd

Comment 5

[Matthew (lilmatt) Willis]

Attachment: AVIARY version of same patch

This is a version of the patch, built for AVIARY

Comment 6

[Matthew (lilmatt) Willis]

Attachment: AVIARY version of moved dtd

same moved dtd from above, but built for AVIARY

Comment 7

[Dave Whipp]

(In reply to comment #1)
> Is there a reason that Thunderbird has never been set to use anything other than
> the system-wide alert sound? If that is an option that is just not going to be
> available, then it should be removed from the preferences altogether

I agree.  Perhaps the option for assigning a custom .wav file should allow the
user to select a sound from the system sounds (aiff, iirc).  Does this
contradict the idea of true cross-platform applications?

Comment 8

[carboncopy]

Still not fix? :(

Am using Thunderbird 1.0.2 and still can't use a custom mail notification sound
selected from the Preferences.

Comment 9

[John]

I hope this isn't going to be the default as 1.1 comes around. The idea that a
new mail sound would be the same as a system alert is kinda silly. This is how
the current alert is in 1.02 and it sucks. I don't know if I made a mistake or
wheterh I have new mail. I wish the custom WAV sound option would actually work.

Comment 10

[Scott MacGregor]

Comment on attachment 159218 [details] [diff] [review]
patch to change Mac lable to "System Alert Sound"

patch is now obsolete. clearing out the review request.

Comment 11

[Scott MacGregor]

Comment on attachment 159219 [details] [diff] [review]
Moved dtd into thunderbird from seamonkey and added Mac-specific ENTITY

patch is now obsolete. clearing out the review request.

Comment 12

[Scott MacGregor]

Comment on attachment 159230 [details] [diff] [review]
AVIARY version of same patch

patch is now obsolete. clearing out the review request.

Comment 13

[Scott MacGregor]

Comment on attachment 159231 [details] [diff] [review]
AVIARY version of moved dtd

patch is now obsolete. clearing out the review request.

Comment 14

[Scott MacGregor]

Attachment: the fix