Closed
Bug 242911
Opened 20 years ago
Closed 19 years ago
Inspector Overlay Changes
Categories
(Firefox :: General, defect, P3)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox1.0beta
People
(Reporter: bugs, Unassigned)
References
Details
(Whiteboard: no l10n impact)
Attachments
(1 file)
For 1.0 bundling, we should create a dynamic overlay for DOM inspector that tweaks the UI a bit to make it fit with Firefox better. Specifically: - align selectors with their labels (this is actually an inspector patch) - remove quit keybinding from File->Exit - remove edit->preferences - find out what Inspector uses as preferences and relocate that to something compatible with our extensions system. - remove tools, window and help menu
Comment 1•20 years ago
|
||
> - remove edit->preferences > - remove tools, window and help menu See bug 241079.
Depends on: 241079
Comment 2•20 years ago
|
||
> - remove quit keybinding from File->Exit Now see the patch in bug 241079 for that as well.
Reporter | ||
Updated•20 years ago
|
Flags: blocking1.0+
Priority: -- → P3
Target Milestone: --- → Firefox1.0beta
Comment 3•20 years ago
|
||
Left to do for this bug: - align selectors with their labels (this is actually an inspector patch) - find out what Inspector uses as preferences and implement in a manner compatible with our extensions system.
Comment 4•20 years ago
|
||
Inspector prefs should be straightforward, it's basically 9 prefs, most of which are pertaining to the highlighting; colour, width of border, duration of flash mozilla/extensions/inspector/resources/content/prefs/pref-inspector.xul http://lxr.mozilla.org/mozilla/source/extensions/inspector/resources/content/prefs/pref-inspector.xul dirtiest/quickest way is to add a file [like browser's pref.xul] that wraps pref-inspector.xul, so that all expected hooks are available.
Comment 5•20 years ago
|
||
Since Steffen keeps unreviewing my prematurely obsoleted patches ... e.g. http://bugzilla.mozilla.org/attachment.cgi?id=137411&action=view Which does what I just suggested, albeit in the dirty/hacky/kludgey/quick specified above.
Comment 6•20 years ago
|
||
Chris is talking about bug 225644.
Comment 7•20 years ago
|
||
Might handle - find out what Inspector uses as preferences and implement in a manner compatible with our extensions system. There is no doubt a better way to handle the pref dialog.
Comment 8•20 years ago
|
||
Comment on attachment 149134 [details] [diff] [review] adds a pref dialog wrapper for seamonkey options panel, tweaks jar.mn and install.rdf This works. It's a kind of hack, but the alternative would be to fork at least pref-inspector.xul and wsm-colorpicker.js. :-/ I would've attached the patch to bug 225644 though, as that is about the prefs dialog, and this bug is more of a meta bug.
Reporter | ||
Updated•20 years ago
|
Flags: blocking-aviary1.0RC1+
Reporter | ||
Updated•20 years ago
|
Assignee: firefox → danm.moz
Reporter | ||
Updated•20 years ago
|
Flags: blocking-aviary1.0RC1+ → blocking-aviary1.0RC1-
Updated•20 years ago
|
Whiteboard: no l10n impact
Reporter | ||
Comment 9•20 years ago
|
||
Not willing to take on addtl' UI to QA before 1.0.
Flags: blocking-aviary1.0+ → blocking-aviary1.0-
Comment 10•19 years ago
|
||
Bug 225644 takes care of the remaining issue: - find out what Inspector uses as preferences and relocate that to something compatible with our extensions system. We don't need this bug to track that, so marking fixed.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•