242988 - improve html we emit for vCards

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Scott MacGregor]

improve html we emit for vCards.  what we do right now is very 199x.

http://lxr.mozilla.org/mozilla/source/mailnews/mime/cthandlers/vcard/mimevcrd.cpp#320

we should do something slicker, take advantage of gecko's css support.

maybe asa or someone in the forums can help.  we'll probably need a few minor
C++ changes to mimevcrd.cpp, and then let people go crazy with their
userContent.css, and when we have a winner, make it the default.

Comment 1

[Scott MacGregor]

started asking for design ideas here:

http://forums.mozillazine.org/viewtopic.php?t=76000

Comment 2

[Scott MacGregor]

Attachment: possible HTML mock up

Here's one possiblity. It gets rid of the "show expanded view" which only works
if you have JS on anyway. Just click the icon and you can either add the card
to the AB or view all of the properties in a rich address book card UI.

Maybe the icon should be top aligned instead of centered...

Comment 3

[Scott MacGregor]

Attachment: more mockups

I added a couple variations:

Moving the icon to the left hand side before the vCard data.
Using a Gray border
Playing with the "curvature" of the border
Aligning the icon on the top
Not collapsing the email address into the name (yielding a much wider vCard)

Comment 4

[Scott MacGregor]

Attachment: attach mockups as PNG's instead of a patch

Comment 5

[Scott MacGregor]

Attachment: work in progress

work in progress patch (although the patch is pretty functional).

Still to do:

1) Hook up the vCard icon to actually run the vCard URL, bringing up the
address book card dialog.

2) the hover state over the vCard icon isn't working yet

We now only show: Name (linkified to personal web page if present), email
adddress, job title department and organization inline with the message. To see
the other elements you bring up the rich ab card dialog.

Comment 6

[Scott MacGregor]

Attachment: finished version

Comment 7

[Scott MacGregor]

Attachment: screen shot of what the patch implements

Comment 8

[Scott MacGregor]

for some reason the moz-image region for the hover state of the icon doesn't
actually work. Other styles applied to this same hover rule do work just not the
moz-image-region.

Comment 9

[Scott MacGregor]

Attachment: updated patch to include changs for OS X