Closed
Bug 243065
Opened 20 years ago
Closed 19 years ago
Making a change to gfx/src/shared does not cause a relink
Categories
(Core Graveyard :: GFX, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.9alpha1
People
(Reporter: caillon, Assigned: cls)
References
Details
Attachments
(1 file, 2 obsolete files)
|
2.42 KB,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
This is quite annoying when editing .cpp files :(
This bug is due to a general dependency problem with our internal libraries. If the library shows up on the link line as -lgfxshared_s, then the dependency rules at http://lxr.mozilla.org/seamonkey/source/config/rules.mk#635 won't work. Rather than trying to check for both static & shared internal library dependencies explicitly, we can add $(DIST)/lib to VPATH and use the GNU make .LIBPATTERNS feature to handle -lfoo dependencies listed in EXTRA_DSO_LIBS.
Attachment #202058 -
Flags: review?(benjamin)
|
||
Comment 2•19 years ago
|
||
Comment on attachment 202058 [details] [diff] [review] v1.0 I think we need to explicitly set .LIBPATTERNS to %.lib on Windows/MSVC and perhaps to lib%.dylib on mac.
Attachment #202058 -
Flags: review?(benjamin) → review-
Good catch. We can use the {DLL,LIB}_{PREFIX,SUFFIX} variables to properly set LIBPATTERNS.
Attachment #202058 -
Attachment is obsolete: true
Attachment #202172 -
Flags: review?(benjamin)
Attachment #202172 -
Flags: review?(benjamin)
Add import libraries to the list. Fixes mingw bustage.
Assignee: general → cls
Attachment #202172 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #202200 -
Flags: review?(benjamin)
|
|
||
Comment 5•19 years ago
|
||
Comment on attachment 202200 [details] [diff] [review] v1.2 Great.
Attachment #202200 -
Flags: review?(benjamin) → review+
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9alpha
|
||
Updated•16 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•