24315 - problems with overlays and popups.

Status: RESOLVED INVALID

(Core :: XUL, defect, P3)

Description

[Scott MacGregor]

I have a popup defined in messenger.xul that looks like:
<popupset>
  <popup id="emailAddressPopup"  popupanchor="bottomleft">
      <menuitem value="&AddToAddressBook.label;"
                oncommand="AddNodeToAddressBook(document.popupElement)"/>
      <menuseparator/>
      <menuitem value="&SendMailTo.label;"
                oncommand="SendMailToNode(document.popupElement)"/>
  </popup>
</popupset>

In the commercial build, I have an overlay which attempts to add a menu item to
this popup:

<popupset>
  <popup id="emailAddressPopup">
      <menuseparator/>
      <menuitem value="insert label"
                oncommand="foo();"/>
  </popup>
</popupset>

When I invoke the popup, I expected to see the menu item I added in the
commercial build inside the popup I defined in messenger.xul. i.e. the two
examples above should be merged into a single popup.

Instead, I only see the contents as defined in messenger.xul. My extra menu item
doesn't show up.

Comment 1

[David Hyatt]

This is bad XUL.  The <overlay> tag's immediate children are the ones that get
merged in.  You don't need a <popupset> over in the overlay.

Comment 2

[Scott MacGregor]

Thanks...removing the popupset fixed it!

Comment 3

[leger]

BULK MOVE: Changing component from XUL to XP Toolkit/Widgets: XUL.  XUL 
component will be deleted.

Comment 4

[shrirang khanzode]

sorry fot the spam, changing QA contact.