244178 - Crash reloading gmail mailbox page

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect)

Description

[Johnny Stenback (:jst)]

When logged into gmail, mozilla (trunk only) will crash if you reload the page.
This is a regression from the recent nsWyciwygChannel changes I made where the
wyciwyg channel now stores the data in the cache as UTF-16, and the channel
actually advertices its charset. This caused child-frames of pages that are
loaded from a wyciwyg channel to assume that their charset is UTF-16 (unless
otherwise specified in the http channel etc), and this exposed a bug in
nsScanner::Append() where it in this case didn't malloc a big enough buffer for
the data it was given (see bug 244177).

We should do two things here, we should make the scanner code not crash (by
fixing bug 244177), and we should also make a document not take the charset from
its parent if its parent is loaded from a wyciwyg channel since there's no
relation between their charsets any more, at all).

Comment 1

[Johnny Stenback (:jst)]

Attachment: Don't advertise the charset of a docshell that's loaded from a wyciwyg: URI (diff -w)

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 148950 [details] [diff] [review]
Don't advertise the charset of a docshell that's loaded from a wyciwyg: URI (diff -w)

s/advertice/advertise/ in the comment, and r=bzbarsky.

Comment 3

[Johnny Stenback (:jst)]

*** Bug 243639 has been marked as a duplicate of this bug. ***

Comment 4

[Darin Fisher]

Comment on attachment 148950 [details] [diff] [review]
Don't advertise the charset of a docshell that's loaded from a wyciwyg: URI (diff -w)

sr=darin

Comment 5

[Johnny Stenback (:jst)]

Fixed.

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

*** Bug 243269 has been marked as a duplicate of this bug. ***

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

*** Bug 245368 has been marked as a duplicate of this bug. ***