245101 - Upgrade from 2.14: attachstatusdefs not found

Status: RESOLVED FIXED

(Bugzilla :: Installation & Upgrading, defect)

Description

[Jouni Heikniemi]

When upgrading from 2.14, I get the following in checksetup:

DBD::mysql::st execute failed: Table 'bugs_214.attachstatusdefs' doesn't exist
at checksetup.pl line 2166.
DBD::mysql::st fetchrow_arrayref failed: fetch() without execute() at
checksetup.pl line 2168.

The migration code doesn't check for existence of attachstatusdefs?

Comment 1

[Dave Miller [:justdave]]

I reproduced this on landfill using one of the older databases still sitting
around on there.  Tracked it down to the code that converts products from names
to IDs.  At the time that was checked in, attachment statuses were still around,
so it's converting the product field on the attachment status table to product_id.

Patch coming up.

Comment 2

[Dave Miller [:justdave]]

Attachment: Patch v1

Comment 3

[Joel Peshkin]

Comment on attachment 152260 [details] [diff] [review]
Patch v1

r=joel
noting that I cannot test it

Comment 4

[Dave Miller [:justdave]]

Here's how you can test this on landfill:

1) Create a bugzilla install running CVS tip using the site tools and make note
of the name of the database it creates for it.
2) $ mysqldrop $dbname
3) $ mysqlclone bugs_bugzilla2_14_branch $dbname
4) $ ./checksetup.pl
5) Verify that the output doesn't contain any errors.

Comment 5

[Dave Miller [:justdave]]

OK, Joel verified in IRC that he could reproduce this and the patch fixed it.
Checking in...

Checking in checksetup.pl;
/cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v  <--  checksetup.pl
new revision: 1.285; previous revision: 1.284
done