245325 - [Contacts side bar is empty in the compose window] and ["Add to Address Book ..." pane isn't filling in]

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[Haris Karahristianidis]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040601 Firefox/0.8.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040601 Firefox/0.8.0+

When I open the window to write a new mail, the contacts side bar is empty,
allthough my address book shows my contacts normaly. This bug exists since 20040602

Reproducible: Always
Steps to Reproduce:
1.
2.
3.

Comment 1

[Haris Karahristianidis]

I forgot to mention that I use the trunk

Comment 2

[Stephen Walker]

Error: setting a property that has only a getter
Source File: chrome://messenger/content/addressbook/abContactsPanel.js
Line: 131

Addressbook searching uses the same code and is broken with the same error:
Error: setting a property that has only a getter
Source File: chrome://messenger/content/ABSearchDialog.js
Line: 113

Regression from bug 244624?

Comment 3

[[e-mail]]

Attachment: Use values correctly

I've only been able to test the Seamonkey version of address book search so in
particular the contacts sidebar changes are a bit of a guess but it's nice
being able delete Seth's code not once but three times :-)

Comment 4

[[e-mail]]

Stephen, any chance you can test this for me? Or should I just ask Scott?

Comment 5

[Stephen Walker]

Everything's back to normal with your patch.  

Are there any tree problems with seamonkey ab search?  Only the left half of a
row is selected in my build.

Comment 6

[[e-mail]]

Sorry, I didn't understand that. Maybe a screenshot would help?

Comment 7

[Stephen Walker]

http://home.bluemarble.net/~walk84/absearch.png

Comment 8

[[e-mail]]

Sorry, I can't reproduce that in my Seamonkey build.

Comment 9

[[e-mail]]

Hmm... address book preferences does this too, sigh...

Comment 10

[Scott MacGregor]

Comment on attachment 149901 [details] [diff] [review]
Use values correctly

thanks for fixing this regression.

Comment 11

[[e-mail]]

Attachment: Patch pref-directory.js

Well I think this fixes everything, but it's tricky trying to figure out just
what the code was doing, or why it was doing it the way it was...

Comment 12

[[e-mail]]

Comment on attachment 149945 [details] [diff] [review]
Patch pref-directory.js

Stephen, would you mind double-checking that this fixes both global directory
preferences and account overrides and handles all cases of renaming or deleting
the currently selected server.

Comment 13

[Stephen Walker]

With the stray line
(http://lxr.mozilla.org/mozilla/source/mailnews/addrbook/prefs/resources/content/pref-directory.js#100)
removed evrything appears to be working, but someone that builds/uses ldap
should test this better.

Tools -> Options -> Attachments also suffers from this bug:
Error: setting a property that has only a getter
Source File: chrome://mozapps/content/downloads/pref-downloads.js
Line: 130

Comment 14

[Stephen Walker]

More of Seth's code for Neil to remove.

New List, New Card, etc: http://lxr.mozilla.org/mozilla/search?string=abPopup.label

Comment 15

[[e-mail]]

Attachment: pref-directory.js patch v2

Comment 16

[[e-mail]]

Attachment: sidebar panel fixes

Also some tb contacts fixes I overlooked :-[

Comment 17

[[e-mail]]

Attachment: new card/list fixes

Stephen, please check these too, thanks.

Comment 18

[Stephen Walker]

Latest set looks good.

Comment 19

[Stephen Walker]

*** Bug 245517 has been marked as a duplicate of this bug. ***

Comment 20

[Gregor Larson]

(In reply to comment #17)
> Created an attachment (id=150001)  new card/list fixes
I applied patch to Thunderbird version 0.6+ (20040604) (nightly) win2k
and my problem (add sender to address book) is fixed. Thanks!

Comment 21

[[e-mail]]

It looks like chuang's bad code predates seth's, so it's not his fault really.

Comment 22

[(not reading, please use [e-mail] instead)]

*** Bug 245613 has been marked as a duplicate of this bug. ***

Comment 23

[(not reading, please use [e-mail] instead)]

> It looks like chuang's bad code predates seth's, so it's not his fault really

if it is addressbook, I'll take the blame.

mscott, this should fix the ["Add to Address Book ..." pane isn't filling in]
bugs that people are reporting for seamonkey and tbird.

Comment 24

[(not reading, please use [e-mail] instead)]

Comment on attachment 150001 [details] [diff] [review]
new card/list fixes

the changes to mozilla/mailnews look good, but you need mscott to approve the
mozilla/mail version.

Comment 25

[David :Bienvenu]

Comment on attachment 150001 [details] [diff] [review]
new card/list fixes

moa=bienvenu (for mscott)

Comment 26

[Scott MacGregor]

*** Bug 245804 has been marked as a duplicate of this bug. ***

Comment 27

[[e-mail]]

Fixes checked in.