246242 - Remove All Sites in prefs is very inefficient

Status: VERIFIED DUPLICATE of bug 236641

(Core :: Networking: Cookies, defect)

Description

[Duncan Greenwood]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4.1) Gecko/20031030
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4.1) Gecko/20031030

Removing all cookie sites seems to rewrite the cookie file for each site entry
removed. Seems to loop through the list, rewriting the cookie file each time.

With 100's of sites this can (and did) take several minutes at 100% CPU. Could
this be a special case in the code and just write an empty file ?


Reproducible: Always
Steps to Reproduce:
1. ensure you have some sites in the list
2. click "Remove All Sites"
3. sit and wait ...

Actual Results:  
Browser takes a significant amount of time to return, using 100% CPU.
eg with 100 sites in the list

open() prefs file
rewrite prefs files with remaining 99
close() file
open() prefs file
rewrite prefs files with remaining 98
close() file
etc ...

Expected Results:  
Just write an empty prefs file

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

I believe that has since been fixed...

Comment 2

[Michiel van Leeuwen (email: mvl+moz@)]

*** This bug has been marked as a duplicate of 236641 ***

Comment 3

[benc]

V/dupe.
Please do not file bugs on anything older than 1.7b....