247322 - No error when installing 0.9 and not 0.9+ compatible extensions in firefox 0.9+

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Teune van Steeg]

User-Agent:       Mozilla/5.0 (Windows; U; Win 9x 4.90; en-US; rv:1.7) Gecko/20040617 Firefox/0.9.0+
Build Identifier: Mozilla/5.0 (Windows; U; Win 9x 4.90; en-US; rv:1.7) Gecko/20040617 Firefox/0.9.0+

When I try to install an extension with em:maxVersion of 0.9 in install.rdf in
firefox 0.9+ no error shows and there is a entry in the Extension Manager which
states: "This Item will be installed after you restart Firefox". But it is not
installed after restarting firefox and the entry in the Extension Manager
persists with the same message.

Reproducible: Always
Steps to Reproduce:
1.Install a 0.9, but not higher version, compatible extension in firefox 0.9+
2.Restart Firefox
3.Look at entry in the Extension Manager

Actual Results:  
A message in the Extension Manager at the extension entry stating "This Item
will be installed after you restart Firefox"

Expected Results:  
Show a warning that the extension is incompatible, and not open the install
extension dialog, so firefox never tries to install the extension when the
versions don't match.

Comment 1

[PikeUK]

This is very similar to Bug 245734, not sure if it's close enough to be
considered a duplicate or not though.

Comment 2

[Steffen Wilberg]

Confirming. If the fix for one bug fixes the other as well, we can still dupe
one to the other.

If you right-click such an extensions and select About, the js console displays:
Error: description has no properties
Source File: chrome://mozapps/content/extensions/about.js
Line: 33

If you disable the extension and restart Firefox, you get the "Finishing
Extension Installation..." dialog; Firefox hangs there.
Closing the dialog and restarting Firefox doesn't help.
You have to clean up or delete profile/extensions/Extensions.rdf to make Firefox
launch again.

I already filed bug 247357 (umo displays extensions and themes with
maxVersion=0.9 for my 0.9.0+ Firefox).

Comment 3

[PikeUK]

(In reply to comment #2)
> Confirming. If the fix for one bug fixes the other as well, we can still dupe
> one to the other.

Fair enough.

> If you right-click such an extensions and select About, the js console displays:
> Error: description has no properties
> Source File: chrome://mozapps/content/extensions/about.js
> Line: 33

That's probably Bug 246429

Comment 4

[Steffen Wilberg]

> > If you right-click such an extensions and select About,
> > the js console displays:
> > Error: description has no properties
> > Source File: chrome://mozapps/content/extensions/about.js
> > Line: 33
> 
> That's probably Bug 246429
Yes indeed, your patch for that bug fixes that.

Comment 5

[PikeUK]

Attachment: Testcase: Once installed all future extension installs hang on restart

Here's a testcase to try with, not only does this never correctly install, but
trying to install any other extension in the same or in a future session
triggers the "Finishing Extension Installation" hang.

Comment 6

[PikeUK]

I'd like to change the summary to something like:

No error when installing extension with maxVersion lower than Firefox version,
any future extension install causes hang

But I won't because I'm not sure if changing summaries like that is OK.

p.s. For reference this bug is also affecting Firefox 0.9 users because the
undoclosetab extension on umo has a maxVersion of 0.8.0+, once they've installed
that all future installs will display the "Finishing..." window.

Comment 7

[PikeUK]

*** Bug 248184 has been marked as a duplicate of this bug. ***

Comment 8

[PikeUK]

The problem is in nsExtensionManager.installExtensionInternal in
nsExtensionManager.js. It calls canInstallItem() which returns -1 for an invalid
version field, 0 for a version field that doesn't match the current app and a
GUID for everything else. However it then does this:

var extensionID = this.canInstallItem(ds);
if (extensionID != -1) {
[...]
}
else if (extensionID == 0)
[...]

So the second case (extensionID == 0) is unreachable since a value of 0 will
always trigger the first case.

Comment 9

[Ben Goodger (use ben at mozilla dot org for email)]

Indeed, discovered this earlier today, FIXED. 

Comment 10

[Ben Goodger (use ben at mozilla dot org for email)]

Indeed, discovered this earlier today, FIXED. 

Comment 11

[PikeUK]

*** Bug 248127 has been marked as a duplicate of this bug. ***

Comment 12

[Steffen Wilberg]

Removing blocking request from fixed bug.

Comment 13

[Asa Dotzler [:asa]]

This isn't fixed for Linux. Tested today's branch build and it resulted in no
warning and then a crash on exit (bug 257196)  If we can avoid that crash by
fixing this for linux, that'd make me smile.

Comment 14

[Brian Ryner (not reading)]

reopening.  The dialog doesn't appear until you exit the application on Windows,
and on Linux it tries to appear on exit but crashes due to re-initializing the
native theme code (bug 257196).

Comment 15

[Ben Goodger (use ben at mozilla dot org for email)]

Can you restate the test case to reproduce? I tried installing the extension in
the first attachment with my patch to 257304, it did not install (showed a
message explaining why, it only works with Firefox 0.8+) 

Comment 16

[Ben Goodger (use ben at mozilla dot org for email)]

the patches I have for 257304 seem to fix the problem bryner was seeing when
installing content holder from umo. 

Comment 17

[Ben Goodger (use ben at mozilla dot org for email)]

Fixed on branch, having merging troubles, will land on trunk shortly

Comment 18

[Steffen Wilberg]

This should be fixed on trunk by the aviary landing.