Closed
Bug 247702
Opened 20 years ago
Closed 20 years ago
[BEOS]Site popups don't resize to content size
Categories
(Core :: XUL, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: sergei_d, Assigned: sergei_d)
References
()
Details
(Keywords: fixed-aviary1.0)
Attachments
(1 file)
730 bytes,
patch
|
thesuckiestemail
:
review+
|
Details | Diff | Splinter Review |
http://beos.spb.ru/mozilla/popups/popup.htm click at "open new window (JavaScript method, skamja 350x195)" link then at "open new window (JavaScript method, fanni 640x480)". Window size for those popups don't follow content size. This happens only if Resize() is called for just created windows. Remedy - for hidden and (yet) invisible windows don't relate on BView/BWindows FrameResized() hook report, but call dipatch NS_RESIZE event explicitly from Resize().
The popups work fine for me. I have changed this in nsWindow::Resize though: //else //{ //inform the xp layer of the change in size OnResize(mBounds); //}
Assignee | ||
Comment 2•20 years ago
|
||
before patch - click on first JS link in testcase page. See result. close popup window. click on second js link. see result. In both case popped windows have bigger size than content. apply patch. do same as above. Windows are sizing to content. (If you don't close first-link window, clicking on second js link opens image in same window and don't resize it, but that's not bug of mozilla, rather bug of page design - different names must be used for windows under both links).
Assignee: jag → sergei_d
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•20 years ago
|
||
Comment on attachment 151274 [details] [diff] [review] patch (diff -up4) review request
Attachment #151274 -
Flags: review?(thesuckiestemail)
Assignee | ||
Comment 4•20 years ago
|
||
per comment http://bugzilla.mozilla.org/show_bug.cgi?id=247702#c1 as mentioned in bug 227733 this causes overhead, especially with current code - OnResize will be called twice for each resize event. Causing additional page recalcualtion/reflow/repaint. Idea of patch is to restrict direct xp calls from Resize() to minimal required cases.
Comment on attachment 151274 [details] [diff] [review] patch (diff -up4) r=thesuckiestemail@yahoo.se
Attachment #151274 -
Flags: review?(thesuckiestemail) → review+
Assignee | ||
Comment 6•20 years ago
|
||
2004-06-20 05:03, rev, 1.81, marking as fixed
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Comment 7•20 years ago
|
||
Checkin on AVIARY by db48x%yahoo.com "Check in several BeOS bugs that are already checked in on the trunk. All are r=twh (thesuckiestemail@yahoo.se) except the last which is r=Sergei Dolgov (sergei_d@fi.tartu.ee). a=carte blanche ([03:53:40] <nielx!~nielx@84.119.151.125> We've been basically given a carte blanche for any change that involves the beos-only code)"
Keywords: fixed-aviary1.0
You need to log in
before you can comment on or make changes to this bug.
Description
•