Closed
Bug 248001
Opened 20 years ago
Closed 20 years ago
Conversion of boolean conditions in SQL statements for better db independence
Categories
(Bugzilla :: Bugzilla-General, defect, P3)
Tracking
()
RESOLVED
FIXED
Bugzilla 2.18
People
(Reporter: dkl, Assigned: dkl)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
3.18 KB,
patch
|
bugreport
:
review+
goobix
:
review+
|
Details | Diff | Splinter Review |
Even though alot have been eliminated, a few instances of having boolean conditions in SQL statements exist. I have created a patch to convert these to equality tests instead for better database independence. For example: SendSQL(" SELECT DISTINCT groups.id, name, description, isactive FROM groups, user_group_map - WHERE user_id = $userid AND NOT isbless + WHERE user_id = $userid AND isbless = 0 AND user_group_map.group_id = groups.id - AND isbuggroup + AND isbuggroup = 1 ORDER BY description "); I am also making this report a blocker on the PostgresSQL support bug.
Assignee | ||
Comment 1•20 years ago
|
||
Assignee | ||
Updated•20 years ago
|
Blocks: bz-postgres
Comment 2•20 years ago
|
||
That's so simple and obviously correct, I think we should just ask for review on it right now and get it checked in. I'll bet bbaetz could do it; he's usually interested in things that block PgSQL. :-)
Comment 3•20 years ago
|
||
Comment on attachment 151391 [details] [diff] [review] Boolean conversion patch for better db independence r=joel
Attachment #151391 -
Flags: review+
Updated•20 years ago
|
Priority: -- → P3
Target Milestone: --- → Bugzilla 2.20
Updated•20 years ago
|
Assignee: justdave → dkl
Flags: approval?
Updated•20 years ago
|
OS: Linux → All
Hardware: PC → All
Target Milestone: Bugzilla 2.20 → Bugzilla 2.18
Updated•20 years ago
|
Flags: approval? → approval+
Comment 4•20 years ago
|
||
dkl: are you checking this in? I could do it for you if you don't have the time, just let me know. Thanks!
Status: NEW → ASSIGNED
Assignee | ||
Comment 5•20 years ago
|
||
Sure. Be my guest. Been swamped here this week with updates. Also am not sure if I can checkin anymore yet since I have yet to send Myk my public key for CVS access. I need to get on that. Dave
Comment 6•20 years ago
|
||
Checking in buglist.cgi; /cvsroot/mozilla/webtools/bugzilla/buglist.cgi,v <-- buglist.cgi new revision: 1.253; previous revision: 1.252 done Checking in editgroups.cgi; /cvsroot/mozilla/webtools/bugzilla/editgroups.cgi,v <-- editgroups.cgi new revision: 1.37; previous revision: 1.36 done Checking in request.cgi; /cvsroot/mozilla/webtools/bugzilla/request.cgi,v <-- request.cgi new revision: 1.13; previous revision: 1.12 done Checking in Bugzilla/Bug.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Bug.pm,v <-- Bug.pm new revision: 1.36; previous revision: 1.35 done
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Comment 7•20 years ago
|
||
Oooops, missed one :-).
Comment 8•20 years ago
|
||
I can't reopen this one, so someone else please...
Comment 9•20 years ago
|
||
Thomas, -- open another bug. If re reopened this one, it would be impossible to tell whicj patch had approval, etc...
Updated•20 years ago
|
Attachment #152673 -
Attachment is obsolete: true
Comment 10•20 years ago
|
||
Comment on attachment 152673 [details] [diff] [review] Aditional patch Moved to bug 250832
Updated•12 years ago
|
QA Contact: matty_is_a_geek → default-qa
You need to log in
before you can comment on or make changes to this bug.
Description
•