248244 - editing mail filters in deferred account uses deferred to account

Status: RESOLVED FIXED

(MailNews Core :: Filters, defect)

Description

[David :Bienvenu]

editing mail filters in deferred account uses deferred to account

Comment 1

[voracity]

(In reply to comment #0)
> editing mail filters in deferred account uses deferred to account

I think you would find most (all?) people using global inbox prefer this
behaviour (if filters would also apply to messages retrieved from deferred
accounts).

So long as there were an additional filter condition for 'Originating account'.

Comment 2

[David :Bienvenu]

yes, ultimately we'd like to be able to have filters on both accounts apply, but
right now, by default, pop3 accounts defer to the local folders account, and we
don't let you edit filters in the local folders account, so I think I need to
fix this.

Comment 3

[David :Bienvenu]

>Thread view is sometimes not remembered.  Expansion/collapse is never
>remembered.  Message unread counts are not correct.

>It appears this occurs when Windoze crashes and Tbird doesn't close normally. 

I'm confused - are all of these a problem only when windows/tbird crashes? Or
are some of them always a problem, and others a problem only when tbird doesn't
shut down cleanly? E.g., you save expand/collapse is never remembered, but it is
for me, at least after a normal shutdown.

Comment 4

[David :Bienvenu]

Attachment: proposed fix

use per-server filters for now, since we don't have an account criteria.

Comment 5

[David :Bienvenu]

Comment on attachment 154114 [details] [diff] [review]
proposed fix

I really need to have a better name for GetRootFolder, so that it's clear we're
getting the actual root, and not the place where we're deferring storage to...

Comment 6

[David :Bienvenu]

fix checked in. If there's not a bug open about applying two sets of filters for
deferred accounts, (one for the originating server, one for the deferred to
server/account), I'll file one.

Comment 7

[Stefan Borggraefe]

(In reply to comment #6)
> fix checked in. If there's not a bug open about applying two sets of filters for
> deferred accounts, (one for the originating server, one for the deferred to
> server/account), I'll file one.

David, I couldn't find a bug about this. Have you forgotten about it or is it
just me being blind? ;-)

Comment 8

[David :Bienvenu]

I haven't even gotten around to searching for an existing bug. But I'll take
your word for it that there's no existing bug and file a new one.

Comment 9

[David :Bienvenu]

Bug 257979 filed for applying multiple filter lists for deferred accounts.