Closed
Bug 248688
Opened 20 years ago
Closed 20 years ago
Thunderbird biff integration refers to the old profile APIs
Categories
(Thunderbird :: Mail Window Front End, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird0.8
People
(Reporter: mscott, Assigned: benjamin)
Details
Attachments
(1 file, 2 obsolete files)
4.42 KB,
patch
|
Details | Diff | Splinter Review |
When starting up the app, nsMessengerWinIntegration trys to use the old profile service in order to get the profile name: http://lxr.mozilla.org/mozilla/source/mailnews/base/src/nsMessengerWinIntegration.cpp#458 We need to add a thunderbird ifdef to use the new APIs. Patch coming up.
Reporter | ||
Updated•20 years ago
|
Status: NEW → ASSIGNED
Target Milestone: --- → Thunderbird0.8
Reporter | ||
Comment 1•20 years ago
|
||
This fix would work except for one problem :). The toolkit profile service is not registered with the component manager in the normal startup case. Only when we are doing the scopeXPCOM startup thing... http://lxr.mozilla.org/mozilla/source/toolkit/xre/nsAppRunner.cpp#913 Benjamin, do you know why the profile service is unavailable for non startup consumers? Is there another way for mailnews to get the name of the current profile like we did with the old profile service API?
Assignee | ||
Comment 2•20 years ago
|
||
There is no such thing as a current profile name, only a current profile path (for instance, you can start the program with thunderbird -profile /path/to/profile. Which is what I think you actually want to do here. Hrm, I thought I already fixed this code, lemme look and see if I forgot to check in a file or checked in something similar already.
Reporter | ||
Comment 3•20 years ago
|
||
Benjamin, did you happen to find that code snippet you were looking for?
Reporter | ||
Comment 4•20 years ago
|
||
Benjamin, did you happen to find that code snippet you were looking for from the semi-single profile landing? I'd like to get this fixed for 0.8 if we can. Thanks!
Assignee | ||
Comment 5•20 years ago
|
||
I couldn't find it, so I just re-created it.
Assignee: mscott → bsmedberg
Attachment #151728 -
Attachment is obsolete: true
Assignee | ||
Comment 6•20 years ago
|
||
Comment on attachment 156591 [details] [diff] [review] use -profile <path> instead of -p <name> Scott, my win32 machine is fried with a bad motherboard, so I can't test this (or even build it).
Attachment #156591 -
Flags: review?(mscott)
Reporter | ||
Comment 7•20 years ago
|
||
Reporter | ||
Updated•20 years ago
|
Attachment #156591 -
Attachment is obsolete: true
Reporter | ||
Updated•20 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•19 years ago
|
Attachment #156591 -
Flags: review?(mscott)
You need to log in
before you can comment on or make changes to this bug.
Description
•