250547 - FlagTypes uses DB dependent comma operator

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, enhancement)

Description

[Tomas Kopal]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040528 Debian/1.6-7
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040528 Debian/1.6-7

As reported and fixed in bug 228917, comma operator can be DB specific. In
Bugzilla/FlagTypes.pm, there is another occurence, which should be replaced by
INNER JOIN. Patch follows.

Reproducible: Always
Steps to Reproduce:

Comment 1

[Tomas Kopal]

Attachment: Patch replacing comma operator with INNER JOIN

Comment 2

[Dave Miller [:justdave]]

Comment on attachment 152677 [details] [diff] [review]
Patch replacing comma operator with INNER JOIN

I don't think the comment change was necessary...  it's still joining by flag
type, and the comment doesn't need to get technical :)

Otherwise this looks good, except that I can't get the patch to apply.	I get
an error about "unexpected end of file" and the patch fails.

Comment 3

[Tomas Kopal]

Attachment: Fixed patch

Comment 4

[Jouni Heikniemi]

Comment on attachment 153570 [details] [diff] [review]
Fixed patch

r=jouni

Comment 5

[Jouni Heikniemi]

Thanks for the patch!

Checking in Bugzilla/FlagType.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/FlagType.pm,v  <--  FlagType.pm
new revision: 1.8; previous revision: 1.7
done