251317 - No UI to add/remove 'My Bugs" link from the footer

Status: RESOLVED FIXED

(Bugzilla :: User Accounts, defect)

Description

[era+mozilla]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040413 Debian/1.6-5
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040413 Debian/1.6-5

I have an old search called "My Bugs" and I cannot figure out how to remove it.
Creating a new with the same name adds a second search with the same name.

The URL to the original "My Bugs" is
<http://bugzilla.mozilla.org/buglist.cgi?bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&email1=era%2Bmozilla%40iki.fi&emailtype1=exact&emailassigned_to1=1&emailreporter1=1>

The URL to the new "My Bugs" which I just added is
<http://bugzilla.mozilla.org/buglist.cgi?cmdtype=runnamed&namedcmd=My%20Bugs>

Presently they are both listed at the bottom of my screen when I log in at
bugzilla.mozilla.org. I imagine that I could replace the new "My Bugs" by
storing a new query with the same name. But there seems to be no way to get rid
of the original "My Bugs".

Reproducible: Always
Steps to Reproduce:
1. Log in
2. Examine bottom of screen
3. Try to change the existing, old "My Bugs" query

Actual Results:  
A new query with the same name was added.

Expected Results:  
Should have replaced the old one.

Also, on the query pane, I note that there is the "clue" link which points to a
page <http://bugzilla.mozilla.org/queryhelp.cgi> which apparently describes how
this worked once upon a time. It shows several options which do not appear in
the current incarnation of the interface; most importantly, "forget the
remembered query" <http://bugzilla.mozilla.org/queryhelp.cgi#therest>.

Comment 1

[Dave Miller [:justdave]]

Run the query first.  The option to delete it is now at the bottom of the
results page.  On bugzilla.mozilla.org you can also visit this url:
http://bugzilla.mozilla.org/page.cgi?id=saved-searches.html
to manage your queries.  On the current Bugzilla which b.m.o hasn't updated to
yet, this is available as a panel in your user preferences.

I'm going to make this bug be for fixing queryhelp.cgi though...  we're in the
release candidate phase for Bugzilla 2.18, and we need to ship it with a help
page that matches the query page that's in it.

Comment 2

[era+mozilla]

Attachment: Screen shot illustrating the two different saved queries

Thanks for the tips and the link, but these also only work on new named
queries. I tried the things you suggested but neither of them allows me to edit
or remove the old "My Bugs" query.

I created a screen shot of the result of the two "My Bugs" queries. The one on
top is the old one; it doesn't have the "Forget Search" link. The one at the
bottom (actually a screen shot within the screen shot :-) is the result of
running the new "My Bugs" query.

Comment 3

[era+mozilla]

I'll post a separate bug about the out of date documentation. To my mind, the
inability to edit or delete a saved search is a bigger problem than inadequate
documentation (if manipulation of old saved searches would work, I probably
wouldn't even look at the documentation). Sorry if this messes up your process.

The old saved search which cannot be edited was probably created back in 2002 or
so, and I've just kept it around since then. Apparently, at some point, you have
moved from "saved" to "named" searches, and I imagine that at that point, old
saved searches should have either been discarded or else upgraded to proper
"named" searches. Well, that didn't happen, and now I'm stuck with an old saved
search which cannot be edited or deleted.

I can't be the only one with an old saved search, only I guess I was the first
one to try to edit an old saved search. (The query never worked right, but I
never needed it to work right before now.)

If nothing else can be done, I'd appreciate if an administrator could remove the
old saved search "by hand" from my settings.

Comment 4

[era+mozilla]

The new bug for the outdated documentation is bug 251502

Comment 5

[Dave Miller [:justdave]]

*** Bug 251502 has been marked as a duplicate of this bug. ***

Comment 6

[Dave Miller [:justdave]]

"My Bugs" isn't a saved search.  It's a separate menu item that happened to show
up in the same section of the footer.  There's already another bug somewhere for
the fact that the UI for adding/removing it disappeared.  I'll find it and be
back in a minute.

Comment 7

[Dave Miller [:justdave]]

OK, all of the related bugs seem to have been duped to bug 133173, which is a
longer term plan to get rid of My Bugs, because it turns out to have been a bad
idea the way it is (as you've discovered. :)

However, that leaves people in a bit of a lurch for 2.18 because some people
will have it and some won't, and there's no way to get it or get rid of it if
you already had it set that way before you upgraded.  So we need to do something
short-term for 2.18.

Apologies for the mixup with the duplicate bug...  I jumped because you set the
blocking+ on it (bzbot announced it on irc), and didn't realize it was you (from
this bug).

Comment 8

[era+mozilla]

Ah, that explains the stupid name -- I'd never call it "My Bugs" other than
ironically. :-)

I'll leave it up to you to decide which bug should belong with which report, but
I'd suggest

  * Use bug 251502 for the doco bug, because it's less messed up and more
focused. In that case, move the blocking+ there from here.

  * Maybe use this report for handling "My Bugs" in 2.18 -- not sure what the
blocking should be then. Or, mark this as a dupe of bug 133173

I kind of like the proposal in 133173 because that was exactly how I expected
this to work when I created a new "My Bugs" named query. There should be a UI
for getting back the original magical "My Bugs" (or removing all kinds of "My
Bugs" from the saved searches) but that could feasibly be saved for later IMHO.

Thanks for your patience

Comment 9

[era+mozilla]

Oops, sorry, didn't mean to change the Component (another bug? Should not change
stuff I didn't actually change :-)

Comment 10

[era+mozilla]

... Coming to think of it, things would already be a lot less confusing if this
wasn't labelled "Saved searches:". As a quick remedy, perhaps the footer could
just be rearranged to set this straight. If it's not a saved search, it should
not be labelled as such.

Comment 11

[Dave Miller [:justdave]]

I think we can do this on 2.18 (add a toggle to add/remove that from the
footer), no point in doing this on the trunk, the trunk can get bug 133173. :)

Comment 12

[Gervase Markham [:gerv]]

OK: so this bug is for adding UI to saved-searches.html.tmpl to add/remove "My
Bugs" from the footer. Then it's probably my problem.

Gerv

Comment 13

[Gervase Markham [:gerv]]

Attachment: Patch v.1

This should do it. I've also rearranged the column order, to something which I
think looks better.

Gerv

Comment 14

[Joel Peshkin]

checked in on both branches