252848 - feature to suppress or route joins, leaves, kills, etc in Chatzilla (message filtering)

Status: NEW

(Other Applications :: ChatZilla, enhancement)

Description

[Mark Dodel]

User-Agent:       Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.8a2) Gecko/20040719
Build Identifier: Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.8a2) Gecko/20040719

I'd like to see the ability in Chatzilla to suppress specific message types, or
route them to a specific tab.  For example Join, Leave and Nick change messages
should be able to be suppressed.   IRCops Wallops might be routed to the server
tab, rather then the current window. I asked on #Chatzilla and was told there
was no preference setting for this and no easy way to do this if at all, at present.

Reproducible: Always
Steps to Reproduce:
1.
2.
3.

Comment 1

[Mike Kaply [:mkaply]]

enhancement

Comment 2

[:Gijs (he/him)]

I will be trying my hand on this for a few weeks (hopefully it won't take
longer, but well...).

My current idea is to use an interface similar to mailnews message filtering,
and allow to copy/move/remove messages back and forth, but I was thinking it
might also be nice to allow specific things to flash the window, make a sound,
or replace words in the message (if the message contains word X, censor that
word to **** or something, similar to bug 119173)

Storage of these rules would use the js object serialiser James Ross wrote. I'm
marking depends only for that bug, but I think the following bugs may be solved
entirely or at least profit from work on this bug:
bug 119173
bug 91447 (not at all sure, it looks like not much code went in for this anyway)
bug 252300
bug 294404

Comment 3

[:Gijs (he/him)]

I was fairly sure I actually took the bug the first time I touched it.
Apparently not. Sorry for bugspam.

Comment 4

[Glen Mailer]

*** Bug 294404 has been marked as a duplicate of this bug. ***

Comment 5

[:Gijs (he/him)]

I got a personal email from Eyal asking if there had been any progress. I regret to say that the answer is mostly 'no', but on the plus side, I'm determined to start work on this after January 6th. Also, we now have a text serializer, so storing all this information is more straightforward then it would have been when this bug was filed, so that should certainly help.

Lastly, there was/is some discussion about what to support and what not to support, and various other arguments about how the architecture should work, on http://wiki.mozilla.org/ChatZilla:Message_Filter

Comment 6

[Wayne Mery (:wsmwk)]

I could swear I'd seen progress on this somewhere, but I must have dreamt it. :)

Can anything useful that can be borrowed from mailnews filters?

Comment 7

[:Gijs (he/him)]

You had probably seen stuff on the wiki. I've been busy with lots of other stuff for some time, but there's a deadline now, or rather, there's supposed to be a deadline. Which is 4 weeks from now, on the release console.

Mailnews is no use because it implements filters in compiled code, so there is nothing to borrow really. Maybe, just maybe, I can reuse some filter manager XUL, but even that would probably take me just as long to write myself, instead of screwing with their implementation.
See also:
http://lxr.mozilla.org/seamonkey/source/mailnews/base/search/public/
http://lxr.mozilla.org/seamonkey/source/mailnews/base/search/resources/content/

On the other hand, I've been growing increasingly sceptical over the performance hit this is going to cause, but I guess we need to look at things one step at a time...

Comment 8

[:Gijs (he/him)]

Oops. Make that 3 weeks just to be clear. Apologies for all the bugspam.

Comment 9

[Wayne Mery (:wsmwk)]

(In reply to comment #6)
> I could swear I'd seen progress on this somewhere, but I must have dreamt it.

ah, I was thinking of Bug 321837 (which indeed would be nice to have on branches)


(In reply to comment #7)
> You had probably seen stuff on the wiki. I've been busy with lots of other
> stuff for some time, but there's a deadline now, or rather, there's supposed to
> be a deadline. Which is 4 weeks from now, on the release console.

deadline?

Comment 10

[:Gijs (he/him)]

Attachment: [Not for checkin or consumption] current state of tree

So, since there was this idea that I wasn't doing anything, I guess it might be nice to show what I have right now. It's far from complete, and some of it is really temporary hackery that needs to be fixed to happen properly, but this should give some ideas. As for the weird brace matching making the last bit of the patch hard to read, you'll have to blame diff I'm afraid (or tell me the magic option to make it do it better).

Comment 11

[:Gijs (he/him)]

Attachment: [not for checkin] updated patch

People kept editing __display, so the old patch bitrotted quite a lot. This one should apply cleanly again. Still not done yet, though. Maybe (hopefully) I'll have time in the Christmas holidays.

Comment 12

[:Gijs (he/him)]

Attachment: [not for checkin] usable patch

Still need to doublecheck sounds, check for random edge cases I forgot about, and poke saving/loading - oh, and no UI yet. But other than that, as far as I can tell this is at least a usable patch.

Comment 13

[Lu Wei]

"conference mode" can do this

Comment 14

[David Vo [:auscompgeek]]

(In reply to comment #13)
> "conference mode" can do this

Conference mode is not as configurable as this.
I apologise for reviving this old bug.

Comment 15

[:Gijs (he/him)]

Realistically, I'm not working on this.

A more sensible path forward might be to fix the deps with individual preferences. :-\