252878 - Undo problems with edit fields

Status: RESOLVED WORKSFORME

(Core :: DOM: Editor, defect)

Description

[Norbert]

User-Agent:       Mozilla/5.0 (Windows; U; Win95; en-US; rv:1.8a3) Gecko/20040722 Firefox/0.9.1+
Build Identifier: Mozilla/5.0 (Windows; U; Win95; en-US; rv:1.8a3) Gecko/20040722 Firefox/0.9.1+

The following problem can be reproduced with all edit-fields of Firefox, for
example the address bar, the search bar, form input fields or the search field
(CTRL+f):

- enter "1111"
- press CTRL+a
- enter "2222"
- press CTRL+a
- enter "3333"
- richt-click "Undo": "3" is shown: This makes no sense because we never have
confirmed a single "3"!
- again richt-click "Undo": "2222" is shown.
- again richt-click "Undo": "2" is shown: The same problem as with the single "3"
- again richt-click "Undo": "1111" is shown"
- again richt-click "Undo": the field is empty.


So we can undo all steps icluding some buggy intermediate steps.

But we cannot redo!

In my oppinion you should fix this so that only one step can be undone and the
next undo does undo the undo, which means it restores the value before the first
undo :-) This would be enough for input fields and fix the problem that all can
be undone but not restored. MS does so in Notepad. :-)
And you should make sure that undo correctly works, I mean the buggy
intermediate steps that restore single digits in above description...

Reproducible: Always
Steps to Reproduce:

Comment 1

[Peter van der Woude [:Peter6]]

confirming (the undo part)

->NEW

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7) Gecko/20040723
Firefox/0.9.1+

Comment 2

[Norbert]

(In reply to comment #0)

sorry for the typing errors:

"richt-click"->"right-click"

Comment 3

[Jesse Ruderman]

-> editor: core

Comment 4

[Norbert]

(In reply to comment #0)

> In my oppinion you should fix this so that only one step can be undone and the
> next undo does undo the undo, which means it restores the value before the first
> undo.
...
> MS does so in Notepad.

"Notepad" was a bad example. But MS does so in it's edit-fields! And you should
do the same because it's more intuitive than you do currently (allowing multiple
undo steps but no redo steps). 

Comment 5

[Wayne Mery (:wsmwk)]

WFM Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060629 Minefield/3.0a1